New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4459 - Make Burn decrypt encrypted payloads after moving/copying to the package cache #93

Merged
merged 1 commit into from Jun 28, 2014

Conversation

Projects
None yet
3 participants
@rseanhall
Member

rseanhall commented Jun 28, 2014

No description provided.

@heaths

This comment has been minimized.

Show comment
Hide comment
@heaths

heaths Jun 28, 2014

Contributor

Looks good.

Contributor

heaths commented Jun 28, 2014

Looks good.

@@ -264,7 +264,7 @@ extern "C" HRESULT CacheCalculatePayloadWorkingPath(
return hr;
}
extern "C" HRESULT CacheCaclulateContainerWorkingPath(

This comment has been minimized.

@barnson

barnson Jun 28, 2014

Member

Aww. I prefer the old pronunciation. :)

@barnson

barnson Jun 28, 2014

Member

Aww. I prefer the old pronunciation. :)

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Jun 28, 2014

Member

This is fine but do we want failure to decrypt to be a noted failure? (An actual question.) Otherwise it turns into a more mysterious error later, no?

Member

barnson commented Jun 28, 2014

This is fine but do we want failure to decrypt to be a noted failure? (An actual question.) Otherwise it turns into a more mysterious error later, no?

@barnson barnson merged commit 6eb1b8a into wixtoolset:develop Jun 28, 2014

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall
Member

rseanhall commented Jun 30, 2014

Like this? rseanhall@d4db083

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Jul 3, 2014

Member

Yes...though I'm concerned that a failure to decrypt (something that's actually encrypted) should be a failure, not just logged as one. Is the install going to fail if there's a failure to decrypt?

Member

barnson commented Jul 3, 2014

Yes...though I'm concerned that a failure to decrypt (something that's actually encrypted) should be a failure, not just logged as one. Is the install going to fail if there's a failure to decrypt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment