Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable coroutine support on every platform #68

Merged
merged 2 commits into from
May 17, 2016
Merged

Enable coroutine support on every platform #68

merged 2 commits into from
May 17, 2016

Conversation

mrzv
Copy link
Contributor

@mrzv mrzv commented May 17, 2016 •
edited
Loading

This change is Reviewable

@mrzv mrzv mentioned this pull request May 17, 2016
Closed
@wjakob
Copy link
Owner

wjakob commented May 17, 2016

A comment: let's enable coroutines on Mac and Linux, but not on Windows.

@wjakob
Copy link
Owner

wjakob commented May 17, 2016

Processing events on a different thread there is fine AFAIK.

@wjakob
Copy link
Owner

wjakob commented May 17, 2016

(I think I actually tested your example3 at some point)

@mrzv
Copy link
Contributor Author

mrzv commented May 17, 2016

How do you check for Linux in your code?

@wjakob
Copy link
Owner

wjakob commented May 17, 2016 

#if defined(__linux__)
...
#endif

@mrzv
Copy link
Contributor Author

mrzv commented May 17, 2016

Ok, I think I got it now.

@wjakob wjakob merged commit de3a3f2 into wjakob:master May 17, 2016
@wjakob
Copy link
Owner

wjakob commented May 17, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrzv @wjakob