Expand add5 to a 2-step process to show partial application #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukestephenson
approved these changes
Aug 19, 2019
| @@ -35,7 +35,10 @@ object IntroExercises { | |||
| * = 9 | |||
| * | |||
| **/ | |||
| def add5(x: Int): Int = ??? | |||
| def add5(x: Int): Int = { | |||
| val f = ??? | |||
There was a problem hiding this comment.
maybe a type annotation on f so that people assign it to the right thing? Otherwise they could just do:
val f = add(5)(x)
f
There was a problem hiding this comment.
Great point! Change made.
I don't understand the CI failure, something to do with oraclejdk :/
There was a problem hiding this comment.
I think the CI has been fixed, might just need a rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you do
addCurried(x)(y), it's not immediately obvious that you can partially applyaddCurried