Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `issubclass` when comparing error types in proxy #47

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
3 participants
@spinda
Copy link
Contributor

commented May 7, 2019

Otherwise this misses ssl.SSLEOFError, for example.

Use issubclass when comparing error types in proxy
Otherwise this misses ssl.SSLEOFError, for example.
@codecov-io

This comment has been minimized.

Copy link

commented May 7, 2019

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   87.18%   87.18%           
=======================================
  Files          17       17           
  Lines        1818     1818           
=======================================
  Hits         1585     1585           
  Misses        233      233
Impacted Files Coverage Δ
seleniumwire/proxy/proxy2.py 51.06% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7687d8...16e8b13. Read the comment docs.

@wkeeling wkeeling merged commit 23d69ea into wkeeling:master May 7, 2019

2 of 3 checks passed

codecov/patch 0% of diff hit (target 87.18%)
Details
codecov/project 87.18% remains the same compared to e7687d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wkeeling

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Thanks for this - definitely better to be using issubclass() here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.