Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying the font spaces fix used in the official qt #38

Merged
merged 1 commit into from Apr 29, 2018

Conversation

Projects
None yet
2 participants
@nicolas-schreiber
Copy link
Contributor

nicolas-schreiber commented Mar 30, 2018

From this PR => https://codereview.qt-project.org/#/c/154801/
This however replaces strings with underscores which is technically changing the font name.
Therefore I propose replacing the space with an escaped space (#20)
I will create another PR for that purpose. You may decide what you like better.

Full disclosure: I did not test this solution, but I believe it works just like in the official qt repository.

This closes #37, closes wkhtmltopdf/wkhtmltopdf#3857, and closes wkhtmltopdf/wkhtmltopdf#3672

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented Apr 29, 2018

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.