C API - TempFiles seem to be deleted early

[tuespetre]

Reference:

tuespetre/TuesPechkin#23

When using the C API, creating a converter and adding multiple objects with HTML byte data results in only the last object being printed with the others showing up blank. The temp files that wkhtmltopdf creates to store the HTML byte data seem to be deleted early, resulting in an error similar to the following for each of the previous objects:

Conversion Warning: Failed loading page file:///C:/Users/grayd/AppData/Local/Temp/wktemp-f19b085a-e516-4151-8786-9dc351d4baa7.html (ignored)

[tuespetre]

I've done my best to track this down:

When conversion is starting, each object is looped through and added as a resource to the loader:

wkhtmltopdf/src/lib/pdfconverter.cc

Line 157 in 06a65fe

for (QList<PageObject>::iterator i=objects.begin(); i != objects.end(); ++i) {

...and as each resource is added to the loader, a temp file is created:

wkhtmltopdf/src/lib/multipageloader.cc

Line 582 in c22928d

LoaderObject * MultiPageLoader::addResource(const QString & string, const settings::LoadPage & s, const QString * data) {

...but when the next temp file is created, the previous one is removed:

wkhtmltopdf/src/lib/tempfile.cc

Line 51 in c22928d

remove();

...so then when the loader loads, the temp files will be missing:

wkhtmltopdf/src/lib/pdfconverter.cc

Line 212 in 06a65fe

#ifdef __EXTENSIVE_WKHTMLTOPDF_QT_HACK__

It looks like the loader needs to have a collection of TempFile objects rather than one that keeps shooting itself in the foot ;)

[ashkulz]

@tuespetre: definitely looks like a bug, but I don't know if I will be able to look into it for a day or two.

[tuespetre]

That's fine, I know how that goes. Is there still time to include this in 0.12.1? I see the milestone on the issue now, nevermind!

[ashkulz]

Milestone changed to 0.12.2 as it doesn't look too easy to address 😦

[poizan42]

Why is it even using temp files? Sounds like a job for a custom protocol handler - or is that too much work to create?

[ashkulz]

Please test the changes and let me know if you encounter an issue, as I'm planning to make the 0.12.2 release in the next week.

[ashkulz]

A release candidate 0.12.2-rc-71e97c1 is available, which should fix this issue. Please report back if your issue is not solved with the above build.

[tuespetre]

This one is all kosher and baller and etc., thank you!

[ashkulz]

0.12.2 has been released, which includes changes related to this issue.