New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/reflect.hh:149: possible bad while test ? #1906

Closed
dcb314 opened this Issue Aug 12, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@dcb314

dcb314 commented Aug 12, 2014

../lib/reflect.hh:149:33: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

    while (name[parmsize] != '\0' || name[parmsize] != '.' || name[parmsize] != '[') ++parmsize;

Suggest swap || for &&.

@ashkulz ashkulz closed this in b8aa754 Nov 20, 2014

@ashkulz

This comment has been minimized.

Member

ashkulz commented Nov 20, 2014

Thanks for the catch!

@ashkulz ashkulz added the Fixed label Nov 20, 2014

@ashkulz ashkulz added this to the 0.12.2 milestone Nov 20, 2014

@ashkulz

This comment has been minimized.

Member

ashkulz commented Nov 22, 2014

A development snapshot 0.12.2-dev-5dea253 is available, which should fix this issue. Please report back if your issue is not solved with the above snapshot.

@ashkulz

This comment has been minimized.

Member

ashkulz commented Jan 10, 2015

0.12.2 has been released, which includes changes related to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment