Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug build of 0.13 fails on windows with missing sicuind.lib #2322

Closed
poizan42 opened this Issue Apr 23, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@poizan42
Copy link
Contributor

poizan42 commented Apr 23, 2015

It's the release version of ICU that is built whether -debug is specified or not, but the build of tools/qlalr tries to link with the debug version.

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented Apr 24, 2015

Does this patch generate both the debug and release libraries? Can't check this right now, unfortunately.

diff --git a/scripts/build.py b/scripts/build.py
index 7fe3411..8d15a42 100755
--- a/scripts/build.py
+++ b/scripts/build.py
@@ -411,7 +417,7 @@ DEPENDENT_LIBS = {
             'msvc*': {
                 'result': ['include/unicode/ucnv.h', 'include/unicode/ustring.h', 'lib/sicuin.lib', 'lib/sicuuc.lib', 'lib/sicudt.lib'],
                 'commands': [
-                    'bash source/runConfigureICU Cygwin/MSVC --enable-release --disable-debug --enable-static --disable-shared --disable-tests --disable-samples --prefix=%(cygdest)s',
+                    'bash source/runConfigureICU Cygwin/MSVC --enable-release --enable-debug --enable-static --disable-shared --disable-tests --disable-samples --prefix=%(cygdest)s',
                     'make', 'make install'
                 ]
             },
@@ -420,7 +426,7 @@ DEPENDENT_LIBS = {
                 'commands': [
                     'cp -R source source.host',
                     'cd source.host; ./configure; make',
-                    'source/configure --host=%(mingw_w64)s --enable-release --disable-debug --enable-static --disable-shared --disable-tests --disable-samples --prefix=%(destdir)s --with-cross-build=`pwd`/source.host',
+                    'source/configure --host=%(mingw_w64)s --enable-release --enable-debug --enable-static --disable-shared --disable-tests --disable-samples --prefix=%(destdir)s --with-cross-build=`pwd`/source.host',
                     'make install']
             }
         }
@poizan42

This comment has been minimized.

Copy link
Contributor Author

poizan42 commented Apr 24, 2015

Unfortunately no. Enabling debug regardless of whether release is enabled results in linking of icu4c/tools/genrb failing with an undefined reference to __imp__CrtDbgReportW. Sounds like it's an issue with ICU.

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented Apr 24, 2015

Does just using --disable-release --enable-debug work? Looks like ICU will have to be special cased in case that works.

@poizan42

This comment has been minimized.

Copy link
Contributor Author

poizan42 commented Apr 24, 2015

Nope, as I just said enabling debug regardsless of whether release is enabled fails.

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented Apr 24, 2015

Sorry didn't read carefully 😦 will need to check it in detail over the weekend.

@poizan42

This comment has been minimized.

Copy link
Contributor Author

poizan42 commented Apr 24, 2015

FYI that link error is expected if you compile against the debug version of the crt (with /MD I think it is), but then link against the release version. So it seems like the build system for ICU gives different flags to cl and link.

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented Apr 27, 2015

I suspect it is something to do with the other libraries (specifically zlib), I'll have to check and confirm.

@ashkulz ashkulz closed this in 7494522 Apr 27, 2015

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented Apr 27, 2015

Please try the latest 0.13 branch, it works (at least goes past building of tools/qlalr) -- if there are any more problems, please reopen the issue. Looking forward to your contributions on wkhtmltopdf/qt#10 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.