rebaselining/upstreaming of patches present in Qt fork

[ashkulz]

This is a tracker bug, which lists changes which need to be ported/applied to the latest Qt. Ideally, all of them should be upstreamed for qtbase + qtsvg. For qtwebkit, we can either try to upstream it to qt (which is unlikely to accept API changes) or to the revived fork.

qtbase

Build-system

• wkhtmltopdf/qt@ac73828 detect patched Qt (only for qtbase)
• wkhtmltopdf/qt@9c10077 run headless on Linux

PDF enhancements

• wkhtmltopdf/qt@baf0626
  • support for external hyperlinks (merged in qt/qtbase@e9eeb68 and qt/qtwebkit@62dd2ad)
  • support for anchors/internal links (Webkit bug, fixed in r208347 and r208398)
  • support for generating PDF outlines (QTBUG-3893)
• wkhtmltopdf/qt@172ef0d fix PDF creation date (merged in qt/qtbase@b5c273c)
• wkhtmltopdf/qt@7658278 support for PDF forms
  • basic AcroForms support
  • add TextField support
  • add CheckBox support
• Add support for rendering PDF form ComboBox qt#7 additional controls in PDF forms
  • add RadioButton support
  • add ComboBox support
  • add HiddenField support
  • add PageJavaScript support
• wkhtmltopdf/qt@6f3def4 allow printing of PDF form elements
• wkhtmltopdf/qt@c6e2d6b regenerate field appearances

Image printing improvements

• wkhtmltopdf/qt@33a8e10 original monolithic patch
• wkhtmltopdf/qt@eced0bb added ARGB32_Premultiplied format support
• Use smart-growing buffer size for compression qt#28 use smart-growing buffer for compression

qtsvg

• wkhtmltopdf/qt@27dfb29
  • optionally clip objects that are outside the viewBox
  • do not output unused/duplicate state objects in QSvgPrintEngine

qtwebkit

Build-system

• wkhtmltopdf/qt@ac73828 detect patched Qt (only for qtwebkit)
• wkhtmltopdf/qt@9c10077 run headless on Linux
• wkhtmltopdf/qt@9c65bf9 build static WebKit
• wkhtmltopdf/qt@8dae19a allow override of screen resolution
• wkhtmltopdf/qt@fe194f9 fix -webkit-debug not being respected

new APIs

• wkhtmltopdf/qt@f4915e5 webpage print control API
  • see comments in Webkit 26584
  • split up into multiple patches, if possible
  • investigate using QPagedPaintDevice
• wkhtmltopdf/qt@874b2a3 using "screen" media-type
• wkhtmltopdf/qt@5509dcd custom print shrinking (used to disable)

bugs

• wkhtmltopdf/qt@0306e5c incorrect page height computation
• wkhtmltopdf/qt@2cbc764 pass page height to printContext

rendering improvements

• wkhtmltopdf/qt@b7c2c15 implement "page-break-inside: avoid"
• wkhtmltopdf/qt@53226bf improve font kerning
• table printing improvements
  • wkhtmltopdf/qt@3e94723 prevent page breaks in table rows
  • wkhtmltopdf/qt@b4ae708 table page-break improvements
  • wkhtmltopdf/qt@71d412b ensure first cell when checking required table height
  • wkhtmltopdf/qt@e4c9c73 handle edge-case with exactly fitting last table row
  • wkhtmltopdf/qt@3ef69db fix segfault if table body does not have a cell at 0,0
  • wkhtmltopdf/qt@d2e9dda suppress blank page if first cell spans multiple pages
  • wkhtmltopdf/qt@409e09a make table page-break logic opt-in
  • wkhtmltopdf/qt@2179f6a Repeat thead and tfoot when table contains page breaks
• DPI-related
  • wkhtmltopdf/qt@198737c avoid truncation of zoom factor used for DPI scaling
  • wkhtmltopdf/qt@f9a0480 do not scale PDF printer based on qt_defaultDpi.
  • wkhtmltopdf/qt@c0cfa03 Implement QWebPage::setDevicePixelRatio

regressions

• QTBUG-52417 web fonts embedded in PDF on Linux

See also PhantomJS regressions for 2.0 and 2.1.

dropped

• wkhtmltopdf/qt@172cf87 msvc: suppress warnings + disable incremental linking for debug builds
• wkhtmltopdf/qt@017c23f ignore untracked files generated during the build
• wkhtmltopdf/qt@7ea5c70 add support for not compressing pdf files
• wkhtmltopdf/qt@efc1371 enable WOFF file support
• wkhtmltopdf/qt@333abde QTextBoundaryFinder: Consider soft hyphen as line breaking opportunity
• wkhtmltopdf/qt@6f02571 Cocoa: Remove references to CMProfileRef and related APIs
• wkhtmltopdf/qt@bc8546d win32-msvc2015: Fix LNK2019: unresolved external symbol
• wkhtmltopdf/qt@aa08ff4 QtWebKit: Fix build with MSVC2015
• wkhtmltopdf/qt@b643990 Segfault fixed. Crash in RenderBlock::removeFloatingObjectsBelow()
• wkhtmltopdf/qt@fe05fcd Add setLineDash function to canvas

[ashkulz]

@poizan42: I'm not really sure how to break up "Image printing improvements", would like your input in that area as mentioned in #3201

[pjeannet]

Following my post on #2916, the only thing I miss in the current alpha are the headers and footers (a huge need for document edition). I tried the stable version but it failed printing both the graphs and layout of my document.

Does the qt versions in your other repositories include these changes? I did not want to spent too much time trying to compile a custom version without knowing if it would work (I ended with a exit code 255 error).

[poizan42]

@ashkulz uhm which commit are you thinking about? The only I can find with something close to that text is cBrain-dk/qtbase-5-wk@555ad18 but that is merely a port of Jakob's commit 4 years ago.

[ashkulz]

@poizan42: I think you split that up into multiple commits for submitting upstream; I was talking about that (there's too many things going on in that commit).

[poizan42]

But it is already upstream: wkhtmltopdf/qt@33a8e10

[ashkulz]

By upstream, I meant to qt .. looking at your fork you practically rewrote a lot of the commit. I don't really understand those changes, so harder for me to upstream it.

[hashimaziz1]

I'm confused on how to read this - does this mean converting HTML forms is not currently supported by wkhtmltopdf?

[ashkulz]

It's supported with the patched Qt, but that isn't accepted by most distributions. I think'll I'll pin this issue after I've updated the website -- you're right, it can be very confusing without explanation 👍

[hashimaziz1]

It's supported with the patched Qt, but that isn't accepted by most distributions. I think'll I'll pin this issue after I've updated the website -- you're right, it can be very confusing without explanation 👍

So what do I need to do to get those features working in WSL2, for example? Will compiling from source be sufficient?

[ashkulz]

@Kaos-Industries this ticket is about upgrading the browser engine used, there's no "source" as yet. Not sure about WSL 2, can you download the packages for a supported distribution and check if they work?

[hashimaziz1]

I use Ubuntu on WSL, but you said somewhere that current distro binaries don't support the patched Qt, which I believe also means those binaries won't support converting HTML form inputs to PDF form inputs.

I'm still fundamentally unclear on whether there are any current binaries (preferably Cygwin, but also open to Ubuntu on WSL and Windows itself) that support converting HTML text fields to fillable PDF text fields, and if not, the steps that need to be taken to get or build a binary that does, such as patching Qt. There really should be documentation to explain this in clear terms.

[ashkulz]

@Kaos-Industries did you go the website and try to see if any of the downloads actually work for you? This is a planning issue for a future release, not a place for general discussion on which features are present or not in the current release.