Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebaselining/upstreaming of patches present in Qt fork #3217

Open
2 of 39 tasks
ashkulz opened this issue Nov 26, 2016 · 12 comments
Open
2 of 39 tasks

rebaselining/upstreaming of patches present in Qt fork #3217

ashkulz opened this issue Nov 26, 2016 · 12 comments
Assignees
Labels
Verified The issue is verified.
Milestone

Comments

@ashkulz
Copy link
Member

@ashkulz ashkulz commented Nov 26, 2016

This is a tracker bug, which lists changes which need to be ported/applied to the latest Qt. Ideally, all of them should be upstreamed for qtbase + qtsvg. For qtwebkit, we can either try to upstream it to qt (which is unlikely to accept API changes) or to the revived fork.

qtbase

Build-system

PDF enhancements

Image printing improvements

qtsvg

  • wkhtmltopdf/qt@27dfb29
    • optionally clip objects that are outside the viewBox
    • do not output unused/duplicate state objects in QSvgPrintEngine

qtwebkit

Build-system

new APIs

bugs

rendering improvements

regressions

See also PhantomJS regressions for 2.0 and 2.1.

dropped

@ashkulz ashkulz added the Verified The issue is verified. label Nov 26, 2016
@ashkulz ashkulz added this to the 0.13.x milestone Nov 26, 2016
@ashkulz ashkulz self-assigned this Nov 26, 2016
@ashkulz
Copy link
Member Author

@ashkulz ashkulz commented Nov 26, 2016

@poizan42: I'm not really sure how to break up "Image printing improvements", would like your input in that area as mentioned in #3201

@pjeannet
Copy link

@pjeannet pjeannet commented Dec 5, 2016

Following my post on #2916, the only thing I miss in the current alpha are the headers and footers (a huge need for document edition). I tried the stable version but it failed printing both the graphs and layout of my document.

Does the qt versions in your other repositories include these changes? I did not want to spent too much time trying to compile a custom version without knowing if it would work (I ended with a exit code 255 error).

@poizan42
Copy link
Contributor

@poizan42 poizan42 commented Dec 5, 2016

@ashkulz uhm which commit are you thinking about? The only I can find with something close to that text is cBrain-dk/qtbase-5-wk@555ad18 but that is merely a port of Jakob's commit 4 years ago.

@ashkulz
Copy link
Member Author

@ashkulz ashkulz commented Dec 7, 2016

@poizan42: I think you split that up into multiple commits for submitting upstream; I was talking about that (there's too many things going on in that commit).

@poizan42
Copy link
Contributor

@poizan42 poizan42 commented Dec 7, 2016

But it is already upstream: wkhtmltopdf/qt@33a8e10

@ashkulz
Copy link
Member Author

@ashkulz ashkulz commented Dec 7, 2016

By upstream, I meant to qt .. looking at your fork you practically rewrote a lot of the commit. I don't really understand those changes, so harder for me to upstream it.

@Kaos-Industries
Copy link

@Kaos-Industries Kaos-Industries commented Jun 7, 2020

I'm confused on how to read this - does this mean converting HTML forms is not currently supported by wkhtmltopdf?

@ashkulz
Copy link
Member Author

@ashkulz ashkulz commented Jun 8, 2020

It's supported with the patched Qt, but that isn't accepted by most distributions. I think'll I'll pin this issue after I've updated the website -- you're right, it can be very confusing without explanation 👍

@ashkulz ashkulz unpinned this issue Jun 8, 2020
@Kaos-Industries
Copy link

@Kaos-Industries Kaos-Industries commented Jun 8, 2020

It's supported with the patched Qt, but that isn't accepted by most distributions. I think'll I'll pin this issue after I've updated the website -- you're right, it can be very confusing without explanation 👍

So what do I need to do to get those features working in WSL2, for example? Will compiling from source be sufficient?

@ashkulz
Copy link
Member Author

@ashkulz ashkulz commented Jun 8, 2020

@Kaos-Industries this ticket is about upgrading the browser engine used, there's no "source" as yet. Not sure about WSL 2, can you download the packages for a supported distribution and check if they work?

@Kaos-Industries
Copy link

@Kaos-Industries Kaos-Industries commented Jun 8, 2020

I use Ubuntu on WSL, but you said somewhere that current distro binaries don't support the patched Qt, which I believe also means those binaries won't support converting HTML form inputs to PDF form inputs.

I'm still fundamentally unclear on whether there are any current binaries (preferably Cygwin, but also open to Ubuntu on WSL and Windows itself) that support converting HTML text fields to fillable PDF text fields, and if not, the steps that need to be taken to get or build a binary that does, such as patching Qt. There really should be documentation to explain this in clear terms.

@ashkulz
Copy link
Member Author

@ashkulz ashkulz commented Jun 9, 2020

@Kaos-Industries did you go the website and try to see if any of the downloads actually work for you? This is a planning issue for a future release, not a place for general discussion on which features are present or not in the current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Verified The issue is verified.
Development

No branches or pull requests

4 participants