Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building for OS X 64bit Fails (-no-openssl) #3680

Closed
RichardD012 opened this Issue Oct 10, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@RichardD012
Copy link

RichardD012 commented Oct 10, 2017

I'm aware of the issues revolving around OSX and openSSL so I've opted to disable openSSL (see PR 3603). This is strictly for a local development environment to test some features that otherwise work when deployed on Windows.

However, a fresh clone is failing in OSX 10.12.6 (Sierra). The latest version of clang installed with XCode throws an error on the following:
HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')

In that specific file, the optionalWidth isn't compared to 0 but optionalHeight is and the optionalHeight line is what's throwing the error.

There's a related bug here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216015

@ashkulz ashkulz added this to the 0.12.5 milestone Apr 30, 2018

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented May 7, 2018

Implemented in bf08ab7.

@ashkulz ashkulz closed this May 7, 2018

@ashkulz ashkulz added the Fixed label May 7, 2018

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented May 30, 2018

A release candidate is available which includes the build system fixes which includes static OpenSSL -- please test and report your findings before the final release. Additionally, I've updated the Travis CI configuration to test the latest Xcode image available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.