Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use git date and commit hash for version numbering. #12

Merged
merged 2 commits into from Feb 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

sodabrew commented Sep 10, 2012

Just an idea here, but using 'git show' we can grab the last commit info and build a version number from it.

@sodabrew sodabrew Use git date and commit hash for version numbering.
Just an idea here, but using 'git show' we can grab the last commit info and build a version number from it.
e35e2a1
Contributor

antialize commented Sep 12, 2012

I like the idea, but it does not seem like the patch would work on windows, (nor I think in wine which is what I use to build the windows binary). Is there any way to accomplice what you do with sed directly in qmake ?

@antialize antialize added a commit that referenced this pull request Feb 9, 2013

@antialize antialize Merge pull request #12 from sodabrew/patch-1
Use git date and commit hash for version numbering.
f8d6aa7

@antialize antialize merged commit f8d6aa7 into wkhtmltopdf:master Feb 9, 2013

Contributor

sodabrew commented Feb 10, 2013

Thanks!

@sodabrew sodabrew deleted the sodabrew:patch-1 branch Feb 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment