New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for ubuntu multiarch dpkg build #2572

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@wfelipe

wfelipe commented Sep 10, 2015

example:
$ dpkg-query -W -f='${Version}' libjpeg-turbo8; echo
1.3.0-0ubuntu21.3.0-0ubuntu2

both version will be appended, now running with a space:
$ dpkg-query -W -f='${Version}'\ libjpeg-turbo8; echo
1.3.0-0ubuntu2 1.3.0-0ubuntu2

when ubuntu has multiarch enabled, dpkg-query will return 2 versions
example:
$ dpkg-query -W -f='${Version}' libjpeg-turbo8; echo
1.3.0-0ubuntu21.3.0-0ubuntu2

both version will be appended, now running with a space:
$ dpkg-query -W -f='${Version}'\  libjpeg-turbo8; echo
1.3.0-0ubuntu2 1.3.0-0ubuntu2
@ashkulz

This comment has been minimized.

Member

ashkulz commented Sep 14, 2015

Can you let me know how this situation can come about? Is multi-arch enabled by default nowadays for Ubuntu?

@wfelipe

This comment has been minimized.

wfelipe commented Sep 14, 2015

it's not enabled by default. If you have multiarch enabled manually, dpkg-query will return two versions, because it runs on the local environment

to enable multiarch (usually i386 and amb64 architectures) [1]:
$ dpkg --add-architecture i386 # on a amd64 system

  1. https://wiki.debian.org/Multiarch/HOWTO
@ashkulz

This comment has been minimized.

Member

ashkulz commented Sep 15, 2015

Correct me if I'm wrong, but this will not happen in the chroot environments -- unless you go and manually enable it and install the alternative packages, right? You're not supposed to touch/reuse the wkhtmltopdf chroot environments for anything else, or you won't have a clean/reproducible build.

@ashkulz ashkulz closed this Sep 15, 2015

@ashkulz ashkulz added the NotNeeded label Sep 15, 2015

@wfelipe

This comment has been minimized.

wfelipe commented Sep 15, 2015

Hi @ashkulz, the only problem is that the get_output is called from the local system, and not in the chroot environment.

I am running a ubuntu amd64, with multiarch enabled, building the amd64 package, and the dpkg-query is called on my system, outside chroot. I'm not touching or reusing wkhtmltopdf, and in fact, i reinstalled the chroot environments a couple of times chasing this problem

@ashkulz

This comment has been minimized.

Member

ashkulz commented Sep 16, 2015

I've only tested it on Debian Jessie (which is clearly stated in the installation instructions). However, it looks like this was broken in fe2e77c, where it should refer to the version inside the chroot.

@ashkulz ashkulz reopened this Sep 16, 2015

@ashkulz ashkulz closed this in 8f03630 Sep 16, 2015

@ashkulz ashkulz added Fixed and removed NotNeeded labels Sep 16, 2015

@ashkulz ashkulz added this to the 0.12.3 milestone Sep 16, 2015

@ashkulz

This comment has been minimized.

Member

ashkulz commented Sep 16, 2015

Thanks! The underlying issue was much more subtle as explained above.

@ashkulz

This comment has been minimized.

Member

ashkulz commented Jan 21, 2016

0.12.3 has been released, which should contain the fix for this issue. Please report back if it is not solved with the above version.

Please note that the distro-specific builds are not built by default from this release onward, see the download FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment