New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements in documentation to makes example of Footer/Header variables more explicit #2887

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@luzfcb
Contributor

luzfcb commented Apr 13, 2016

  • Use decodeURI instead of unescape, because unescape is deprecated
  • Rename variable to more explicit code is easier to understand (Yes, it took me a little time to understand what the previous code does)
  • Updated the variables (see css_selector_classes list) to contain only the variables currently available in wkhtmltopdf
makes example of Footer/Header variables more explicit
* Use "decodeURI" instead of "unescape", because "unescape" is deprecated
* Rename variable to more explicit code is easier to understand
* Updated the variables (see css_selector_classes ) to contain only the variables currently available in wkhtmltopdf

@ashkulz ashkulz added the Merged label Apr 14, 2016

@ashkulz ashkulz added this to the 0.12.4 milestone Apr 14, 2016

@ashkulz

This comment has been minimized.

Member

ashkulz commented Apr 14, 2016

Merged in b2cefd7.

@ashkulz ashkulz closed this Apr 14, 2016

@luzfcb luzfcb deleted the luzfcb:patch-1 branch Apr 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment