New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing PDF global setting #3291

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
2 participants
@a-ctor
Contributor

a-ctor commented Jan 15, 2017

The c-bindings page states that there is a outlineDepth property accessible for the global settings object.

Trying to get or set the setting via wkhtmltopdf_get_global_setting or wkhtmltopdf_set_global_setting will not work as the WKHTMLTOPDF_REFLECT part is missing for the outlineDepth field.

Added missing PDF global setting
The [doc](http://wkhtmltopdf.org/libwkhtmltox/pagesettings.html#pagePdfGlobal) states that there is a `outlineDepth` property accessible on the global setting object but setting or getting the setting will not work as the `WKHTMLTOPDF_REFLECT` for that property is missing.

@ashkulz ashkulz merged commit 2b1ed87 into wkhtmltopdf:master Jan 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ashkulz

This comment has been minimized.

Member

ashkulz commented Jan 16, 2017

Thanks for the contribution!

@ashkulz ashkulz added this to the 0.12.5 milestone Jan 16, 2017

@ashkulz ashkulz added the Merged label Jan 16, 2017

@a-ctor a-ctor deleted the a-ctor:patch-2 branch Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment