New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error message for network errors related to non-media files #3363

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
2 participants
@dmlambea
Contributor

dmlambea commented Mar 2, 2017

If a network error occurs and the URL is not detected as media file, the converter exits with exit code 1 but no errors are logged, which makes debugging difficult. This PR adds an error message to that case.

@ashkulz ashkulz merged commit e43bbb9 into wkhtmltopdf:master Mar 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashkulz ashkulz added the Merged label Mar 2, 2017

@ashkulz ashkulz added this to the 0.12.5 milestone Mar 2, 2017

@dmlambea dmlambea deleted the dmlambea:extralogging branch Mar 3, 2017

@ashkulz

This comment has been minimized.

Member

ashkulz commented May 30, 2018

A release candidate is available which includes the fixes made in this PR -- please test and report your findings before the final release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment