Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DPI issue on OS X #3386

Merged
merged 1 commit into from Mar 15, 2017

Conversation

3 participants
@pvandertak
Copy link

pvandertak commented Mar 12, 2017

On OS X, the resolution is clamped to default output device's supported resolutions. Then, when changing the device to PDF, the clamped value would be used, rather than the desired resolution. This typically resulted in tiny text, possibly more likely on retina displays. Simply setting the resolution after the PDF format is selected fixes the issue.

This was tested on OS X and fixes #3241 (see there for details)

Peter van der Tak
Fix for DPI issue on OS X.
On OS X, the resolution is clamped to default output device's supported resolutions. Then, when changing the device to PDF, the clamped value would be used, rather than the desired resolution. Simply setting the resolution after the PDF format is selected fixes the issue.

@ashkulz ashkulz merged commit 1c0e72d into wkhtmltopdf:master Mar 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented Mar 15, 2017

Thanks!

@ashkulz ashkulz added the Merged label Mar 15, 2017

@ashkulz ashkulz added this to the 0.12.5 milestone Mar 15, 2017

@jwhitmarsh

This comment has been minimized.

Copy link

jwhitmarsh commented Apr 11, 2017

@ashkulz Is there a temporary workaround until this is released?

@pvandertak pvandertak deleted the pvandertak:dpi_fix_osx branch Apr 11, 2017

@pvandertak

This comment has been minimized.

Copy link
Author

pvandertak commented Apr 11, 2017

I don't think there is a proper workaround, aside compiling it yourself. You could try playing with the --dpi, --zoom and --lowquality options, but I don't think you'll be able to get a correct result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.