New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added viewportSize to ReflectImpl<PdfGlobal> #3440

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
2 participants
@rdvojmoc
Contributor

rdvojmoc commented Apr 18, 2017

@ashkulz Is this enough or needs to be added also somewhere else. I checked pdfsettings.hh and viewportSize is already defined

Proposed fix for issue #2609

nbosscher added a commit to nbosscher/wkhtmltox that referenced this pull request Apr 19, 2017

@ashkulz ashkulz merged commit 3bf2f1e into wkhtmltopdf:master Jun 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ashkulz

This comment has been minimized.

Member

ashkulz commented Jun 8, 2017

Thanks!

@ashkulz ashkulz added the Merged label Jun 8, 2017

@ashkulz ashkulz added this to the 0.12.5 milestone Jun 8, 2017

@ashkulz

This comment has been minimized.

Member

ashkulz commented May 30, 2018

A release candidate is available which includes the fixes made in this PR -- please test and report your findings before the final release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment