Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation of readonly form fields #3550

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
2 participants
@skennedy
Copy link
Contributor

skennedy commented Jul 6, 2017

Fix translation of readonly form fields
- the javascript property to test for `<input readonly>` is actually `this.readOnly`
- https://www.w3schools.com/jsref/prop_text_readonly.asp

@ashkulz ashkulz merged commit 163e124 into wkhtmltopdf:master Aug 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashkulz ashkulz added the Merged label May 30, 2018

@ashkulz ashkulz added this to the 0.12.5 milestone May 30, 2018

@ashkulz

This comment has been minimized.

Copy link
Member

ashkulz commented May 30, 2018

A release candidate is available which includes the fixes made in this PR -- please test and report your findings before the final release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.