New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fflush call to end of ProgressFeedback functions #3583

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
2 participants
@jamyspex

jamyspex commented Jul 31, 2017

stderr was being buffered when using with C# Process object and I couldn't get real-time progress feedback, as you had to wait for the buffer to fill up.

Tested on windows 10 x64 output is available line by line as it is output.

Added fflush call to end of ProgressFeedback functions as stderr was …
…being buffered when using with C# Process object and I couldn't get realtime progress feedback

@ashkulz ashkulz merged commit 147b9f1 into wkhtmltopdf:master Aug 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashkulz ashkulz added the Merged label May 30, 2018

@ashkulz ashkulz added this to the 0.12.5 milestone May 30, 2018

@ashkulz

This comment has been minimized.

Member

ashkulz commented May 30, 2018

A release candidate is available which includes the fixes made in this PR -- please test and report your findings before the final release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment