New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query string from failed url, before handling error #3593

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@NiR-
Contributor

NiR- commented Aug 5, 2017

Currently wkhtmltox don't ignore media errors for URL with a query string whereas
load-media-error-handling takes 'ignore' value. This is due to QFileInfo::completeSuffix()
returning extension as well as qs.

This little fix circumvents this issue by removing everything using regexp: \?.*$.

Remove query string from failed url, before handling error
Currently wkhtmltox don't ignore media errors for URL with a query string whereas
load-media-error-handling takes 'ignore' value. This is due to QFileInfo::completeSuffix()
returning extension as well as qs.

This little fix circumvents this issue by removing everything using regexp: '\?.*$'.

@ashkulz ashkulz merged commit 333521a into wkhtmltopdf:master Aug 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@NiR- NiR- deleted the NiR-:fix-ignore-media-with-qs branch Aug 18, 2017

@ashkulz ashkulz added the Merged label May 30, 2018

@ashkulz ashkulz added this to the 0.12.5 milestone May 30, 2018

@ashkulz

This comment has been minimized.

Member

ashkulz commented May 30, 2018

A release candidate is available which includes the fixes made in this PR -- please test and report your findings before the final release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment