New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application name in libwkhtmltox (bug #3476) #3878

Merged
merged 1 commit into from Apr 29, 2018

Conversation

Projects
None yet
3 participants
@julego
Contributor

julego commented Apr 14, 2018

Forced setting the right QCoreApplication::applicationName in libwkhtmltox, fixing weird bugs on the User-Agent definition

@Geolim4

This comment has been minimized.

Geolim4 commented Apr 16, 2018

@ashkulz Can you merge this please, this is actually a serious bug that affect every http calls made by the lib...

@ashkulz ashkulz merged commit 29f5f7e into wkhtmltopdf:master Apr 29, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@ashkulz ashkulz added this to the 0.12.5 milestone Apr 29, 2018

@ashkulz

This comment has been minimized.

Member

ashkulz commented Jun 4, 2018

So, I'd like to request you to test the latest release candidate which has 6f77c46 and should ideally be tested via the API to see everything works normally.

I'm planning to release 0.12.5 this weekend, so would appreciate feedback before that -- I'm open to delaying it if a fix is needed.

@julego

This comment has been minimized.

Contributor

julego commented Jun 5, 2018

I've tested the library based on your Jessie & Stretch 0.12.5-rc debs, the right User-Agent is correctly set. The tests were done with the php-wkhtmltox PHP extension, on both PHP 5.6 and PHP 7.0 versions.

I think you're good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment