Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

ensure that temp file is cleaned up when using the c bindings #3930

Merged
merged 1 commit into from May 26, 2018

Conversation

robinbetts
Copy link
Contributor

When using the c bindings to convert to pdf, as done by wrappers such as TuesPechkin, wktemp files were being left behind after conversion due to the temp file not being closed properly.

@ashkulz
Copy link
Member

ashkulz commented May 25, 2018

can you please reference the issue numbers? pretty sure reported earlier...

@robinbetts
Copy link
Contributor Author

May relate to issue #1981 although this was closed after a fix which worked for conversions at the command line.

@ashkulz
Copy link
Member

ashkulz commented May 26, 2018

Thanks for the contribution!

@ashkulz ashkulz added this to the 0.12.5 milestone May 26, 2018
@ashkulz ashkulz added the Merged label May 26, 2018
@ashkulz
Copy link
Member

ashkulz commented Jun 4, 2018

So, I'd like to request you to test the latest release candidate which has 6f77c46 and should ideally be tested via the API to see everything works normally.

I'm planning to release 0.12.5 this weekend, so would appreciate feedback before that -- I'm open to delaying it if a fix is needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants