Fix a bug I thought i fixed before

wlandau · wlandau · commit 36e98ae76feb · 2024-11-14T16:48:20.000-05:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -14,7 +14,7 @@ Description: Intense parallel workloads can be difficult to monitor.
   visualize the log file to reveal potential resource-related
   reasons for the crash. The 'autometric' package borrows heavily from
   the methods of packages 'ps' <doi:10.32614/CRAN.package.ps> and 'psutil'.
-Version: 0.1.1.9001
+Version: 0.1.2
 License: MIT + file LICENSE
 URL:
   https://wlandau.github.io/autometric/,
diff --git a/NEWS.md b/NEWS.md
@@ -1,7 +1,8 @@
-# autometric 0.1.1.9001
+# autometric 0.1.2
 
 * Plot the last PID by default.
 * Speed up `log_phase_set()`.
+* Do not overwrite null character in `strncpy()`.
 
 # autometric 0.1.1
 
diff --git a/inst/WORDLIST b/inst/WORDLIST
@@ -17,3 +17,4 @@ codecov
 pkgdown
 CloudWatch
 SLURM
+PID
diff --git a/src/thread.c b/src/thread.c
@@ -87,7 +87,7 @@ void pthread_phase_reset(void) {
 
 void pthread_phase_set(const char* phase) {
   pthread_mutex_lock(&run_mutex);
-  strncpy(run_phase, phase, PHASE_N);
+  strncpy(run_phase, phase, PHASE_N - 1);
   run_phase[PHASE_N - 1] = '\0';
   pthread_mutex_unlock(&run_mutex);
 }
diff --git a/src/version.h b/src/version.h
@@ -1 +1 @@
-#define VERSION "0.1.1.9001"
+#define VERSION "0.1.2"

-Original file line number
+Diff line change
 pkgdown
 CloudWatch
 SLURM
 +PID
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ void pthread_phase_reset(void) {`
`87`	`87`
`88`	`88`	`void pthread_phase_set(const char* phase) {`
`89`	`89`	`pthread_mutex_lock(&run_mutex);`
`90`		`- strncpy(run_phase, phase, PHASE_N);`
	`90`	`+ strncpy(run_phase, phase, PHASE_N - 1);`
`91`	`91`	`run_phase[PHASE_N - 1] = '\0';`
`92`	`92`	`pthread_mutex_unlock(&run_mutex);`
`93`	`93`	`}`