New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the assertion in the survey module. #24

Merged
merged 5 commits into from Jul 8, 2016

Conversation

Projects
None yet
2 participants
@CdavM
Contributor

CdavM commented Jul 8, 2016

No description provided.

# often than once every hour.
assert not latest_stored_graph or timezone.now() - streams[0]['latest_datapoint'] >= datetime.timedelta(hours=1)
# Since a new survey is performed once every two hours,
# new data should only be inserted once in that time period.

This comment has been minimized.

@mitar

mitar Jul 8, 2016

Member

Maybe also explain that it is not a problem if it is done more often, because the maximum granularity setting is only an optimization.

@mitar

mitar Jul 8, 2016

Member

Maybe also explain that it is not a problem if it is done more often, because the maximum granularity setting is only an optimization.

This comment has been minimized.

@mitar

mitar Jul 8, 2016

Member

And no data is lost.

@mitar

mitar Jul 8, 2016

Member

And no data is lost.

@mitar

This comment has been minimized.

Show comment
Hide comment
@mitar

mitar Jul 8, 2016

Member

LGTM.

But do you know why surveys are more often than one hour? We should debug that as well.

Member

mitar commented Jul 8, 2016

LGTM.

But do you know why surveys are more often than one hour? We should debug that as well.

@mitar mitar merged commit 28e9b93 into wlanslovenija:development Jul 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment