New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue node detection algorithm implementation. #25

Closed
wants to merge 9 commits into
base: development
from

Conversation

Projects
None yet
2 participants
@CdavM
Contributor

CdavM commented Jul 14, 2016

This PR should be used to discuss the rogue node algorithm implementation. Note that this PR depends on features in my export-survey-data PR.

@@ -56,3 +56,4 @@ git+https://github.com/wlanslovenija/django-rest-framework-gis.git@d6e9678c1bc10
git+https://github.com/wlanslovenija/drf-ujson-renderer.git@96cee399260daf469b7e4b004fa245edf9dd253c#egg=drf_ujson-wlanslovenija
grako==3.8.1
influxdb==2.12.0
networkx==1.11

This comment has been minimized.

@CdavM

CdavM Jul 14, 2016

Contributor

Is this the right file to add a package? It seems odd because the -readthedocs ending of the filename implies this is used only for the documentation.

@CdavM

CdavM Jul 14, 2016

Contributor

Is this the right file to add a package? It seems odd because the -readthedocs ending of the filename implies this is used only for the documentation.

This comment has been minimized.

@mitar

mitar Jul 14, 2016

Member

It is. This one lacks some binary packages which cannot be installed on readthedocs.

(We will see if networkx can be installed on readthedocs - if not, then we should move it to requirements.txt.)

@mitar

mitar Jul 14, 2016

Member

It is. This one lacks some binary packages which cannot be installed on readthedocs.

(We will see if networkx can be installed on readthedocs - if not, then we should move it to requirements.txt.)

@CdavM CdavM changed the title from Rogue node detection to Rogue node detection algorithm implementation. Jul 14, 2016

@CdavM

This comment has been minimized.

Show comment
Hide comment
@CdavM

CdavM Jul 21, 2016

Contributor

Can I get a code review on this? (although the checks are failing)

Contributor

CdavM commented Jul 21, 2016

Can I get a code review on this? (although the checks are failing)

@CdavM

This comment has been minimized.

Show comment
Hide comment
@CdavM

CdavM Jul 25, 2016

Contributor

Rebasing these commits to a PR with a branch created within nodewatcher.

Contributor

CdavM commented Jul 25, 2016

Rebasing these commits to a PR with a branch created within nodewatcher.

@CdavM CdavM closed this Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment