New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC: Updating the map #69

Open
wants to merge 5 commits into
base: development
from

Conversation

Projects
None yet
4 participants
@MarinStevic
Contributor

MarinStevic commented Jul 18, 2018

This is an update to the current nodewatcher map. I have added:

  • Fulscreen option
  • Popup with some general information about the node that you get when you click on it. And also by clicking the name in the popup you can go to that nodes page
  • Sidebar that gives you a list of all currently online nodes with a search bar and the ability to locate each node on the map
  • Sidebar also shows all nodes that have gone offline in the past 24 hours
  • Updated the markercluster.js to work with the new leaflet.js
  • Leaflet markercluster and fullscreen are now gathered through CDN so they will be the newest version
}
/* Do not combine these two rules; IE will break. */
.leaflet-container:-webkit-full-screen {

This comment has been minimized.

@CdavM

CdavM Jul 21, 2018

Contributor

Where is this used?

@CdavM

CdavM Jul 21, 2018

Contributor

Where is this used?

@@ -9,6 +9,16 @@
{% add_data "js_data_end" "leaflet/js/leaflet.markercluster.js" %}
{% add_data "css_data" "leaflet/css/leaflet.markercluster.css" %}
{% add_data "js_data_end" "leaflet/js/leaflet.fullscreen.js" %}

This comment has been minimized.

@CdavM

CdavM Jul 21, 2018

Contributor

Indentation?

@CdavM

CdavM Jul 21, 2018

Contributor

Indentation?

@@ -19,7 +29,7 @@
{% block content %}
{% leaflet_map "map" %}

This comment has been minimized.

@CdavM

CdavM Jul 21, 2018

Contributor

?

@CdavM

CdavM Jul 21, 2018

Contributor

?

Added recently offline nodes list
Added list of nodes that went offline in the past 24h, updated some parts of the code and added comments.

@MarinStevic MarinStevic changed the title from Updating the map to GSoC: Updating the map Jul 31, 2018

@MarinStevic MarinStevic closed this Aug 1, 2018

@MarinStevic MarinStevic reopened this Aug 1, 2018

@@ -0,0 +1,80 @@
//Add nodes to the map sidebar table

This comment has been minimized.

@mitar

mitar Aug 27, 2018

Member

Code style in this file is strange. Some functions have four spaces indentation, some two. Please make it the same as other JS files in the project.

@mitar

mitar Aug 27, 2018

Member

Code style in this file is strange. Some functions have four spaces indentation, some two. Please make it the same as other JS files in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment