Will Madden wmadden

wmadden commented on pull request OiNutter/node-build#46
@wmadden

@OiNutter this'd be really helpful

wmadden created branch master at wmadden/tock-es6
wmadden created repository wmadden/tock-es6
wmadden commented on pull request marionettejs/backbone.syphon#108
@wmadden

@samccone any progress here?

@wmadden

I think the best approach is to leave this to the consumer of the library, using Autoprefixer for example. Otherwise you have to make assumptions a…

@wmadden
wmadden commented on pull request marionettejs/backbone.syphon#108
@wmadden

@samccone I rewrote it using @rhubarbselleven's type selection code. This is now easy for people to customize if they want to. I'm also requesting …

@wmadden
@wmadden
@wmadden
@wmadden
  • @wmadden 209a42c
    Use jQuery to test if an input is disabled
@wmadden
  • @wmadden 2fe3b38
    Use jQuery to test if an input is disabled
@wmadden
wmadden deleted tag v0.7.0 at goderma/backbone.syphon
@wmadden
wmadden commented on pull request marionettejs/backbone.syphon#108
@wmadden

Good point @samccone. I'd still opt to ignore disabled elements by default since that's the behaviour implemented by browsers. I think if someone w…

@wmadden
wmadden commented on pull request marionettejs/backbone.syphon#108
wmadden commented on pull request marionettejs/backbone.syphon#108
@wmadden

@samccone yes.

@wmadden
@wmadden
  • @wmadden 8ce8a6e
    Update tests to use Chai matchers
@wmadden
@wmadden
  • @wmadden 4f9b118
    Simplified `getInputElements()` to silence the linter
@wmadden
Ignore disabled fields
3 commits with 60 additions and 12 deletions
@wmadden
  • @wmadden f9058b0
    Simplified `getInputElements()` to silence the linter