Unconditionally require numpy #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not requiring it when it is already installed breaks Debian package builds, which use setup.py install and translate requires to Debian package Depends. SciPy has reverted back to unconditionally requiring numpy too. Fixes: https://bugs.debian.org/1030653 See-also: scipy/scipy#12727 See-also: scipy/scipy#12729 See-also: scipy commit 988d69724c8ee963e45f8fedf9cba1ca18bf941d Reverts: wmayner#38 Reverts: commit b0dde3b.
|
Thanks for the heads up on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not requiring it when it is already installed breaks Debian package builds,
which use setup.py install and translate requires to Debian package Depends.
SciPy has reverted back to unconditionally requiring numpy too.
CC: @TimothyFitz
Fixes: https://bugs.debian.org/1030653
See-also: scipy/scipy#12727
See-also: scipy/scipy#12729
See-also: scipy commit 988d69724c8ee963e45f8fedf9cba1ca18bf941d
Reverts: #38
Reverts: commit b0dde3b