From 0cb0d931f2b43e9d399acfa8ec4bdb0dc8652674 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thiemo=20M=C3=A4ttig?= Date: Thu, 20 Jul 2017 17:30:32 +0200 Subject: [PATCH] Make unused GlobeCoordinate.getDecimal private --- lib/globeCoordinate/globeCoordinate.GlobeCoordinate.js | 8 ++++---- src/values/GlobeCoordinateValue.js | 2 -- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/globeCoordinate/globeCoordinate.GlobeCoordinate.js b/lib/globeCoordinate/globeCoordinate.GlobeCoordinate.js index c588cae..6de6b40 100644 --- a/lib/globeCoordinate/globeCoordinate.GlobeCoordinate.js +++ b/lib/globeCoordinate/globeCoordinate.GlobeCoordinate.js @@ -30,8 +30,6 @@ this._longitude = gcDef.longitude; this._precision = gcDef.precision || null; - // TODO: Capture altitude and globe - // TODO: Implement globe specific restrictions. The restrictions below // allow coordinates for Mars and other globes. if( Math.abs( this._latitude ) > 360 ) { @@ -44,6 +42,9 @@ this._globe = gcDef.globe || 'http://www.wikidata.org/entity/Q2'; }; + /** + * @class globeCoordinate.GlobeCoordinate + */ SELF.prototype = { // Don't forget about "constructor" since we are overwriting the whole prototype here: constructor: SELF, @@ -107,9 +108,8 @@ getPrecision: function() { return this._precision; }, /** - * Returns an object with decimal latitude, longitude and precision. - * * @return {Object} + * @private */ getDecimal: function() { return { diff --git a/src/values/GlobeCoordinateValue.js b/src/values/GlobeCoordinateValue.js index 9a974be..4bd1c86 100644 --- a/src/values/GlobeCoordinateValue.js +++ b/src/values/GlobeCoordinateValue.js @@ -75,7 +75,6 @@ var SELF longitude: globeCoordinate.getLongitude(), globe: globeCoordinate.getGlobe(), precision: globeCoordinate.getPrecision() - // altitude: ... }; } } ); @@ -91,7 +90,6 @@ SELF.newFromJSON = function( json ) { longitude: json.longitude, globe: json.globe, precision: json.precision - // altitude: json.altitude, // TODO: make globeCoordinate.js support altitude } ); return new SELF( gc );