Release 1.0.0

[manicki]

Probably any changes to the npm package name (see #126 (comment)) should be made before this gets merged.

[manicki]

I realized the package might not be ready for the release yet. Will re-open after I am sure it is ready.

[thiemowmde]

You will probably say this is unrelated, but I'm proposing a 0.9 release for a while now. I would find it very, very helpful to merge these two pull requests (#122 and #123) first. Otherwise we might release 2.0 one week after 1.0, and that would feel silly.

[manicki]

Regarding the 0.9 release. Didn't you release 0.9.0 a month ago: https://github.com/wmde/DataValuesJavaScript/releases/tag/0.9.0 ?

Those changes are unrelated to what I am looking at currently but I don't see a reason why not to include them in the next release. That said:

• I don't know what those changes are about. As I don't know them, and they're not part of something I am committed, I am not going to commit to review those patches any time soon. Sorry but I prefer to be clear on this.
• To me making a release dropping the PHP code has quite a high priority so I would not like to wait too long for other changes to be included. I.e. I'd rather have two possible major release in several weeks, than wait several weeks for a single release

[manicki]

Just in case my previous comment sounded harsh: I really do understand willing to avoid breaking changes etc. But on the other hand I believe the balance is the key. And I'd rather have more major version than delay high priority work in order to avoid breaking changes. Especially in case we have here that all users of this lib are actually in our control, so breaking changes are not that much of a problem.

[thiemowmde]

Yes, I released 0.9 to get stuff unstuck, and planned to do a 0.10 release for #122 and #123. Now you are proposing a 1.0, which replaces my plan for a 0.10, I guess. So #122 and #123 should be in 1.0.

A possible solution is to change the proposed 1.0 back to 0.10. Releasing a 0.11 one week after a 0.10 would feel much less silly than releasing a 2.0 one week after a 1.0.

[manicki]

Could change a version number for now, yes. Does not make much of difference for me to be honest.
The argument in favour of going up to 1.0.0 right away now is that this package is used in production (and is so for a while actually). To quote semver:

If your software is being used in production, it should probably already be 1.0.0.