Permalink
Browse files

Merge pull request #832 from wmde/TemplateTestCampaignTest

Fixed risky test in TemplateTestCampaignTest
  • Loading branch information...
2 parents 76d31e4 + 6ea0093 commit 4081da6b5438af3cd8d5673d9472790fe114379a @KaiNissen KaiNissen committed on GitHub Feb 15, 2017
Showing with 9 additions and 9 deletions.
  1. +9 −9 tests/Unit/Presentation/TemplateTestCampaignTest.php
@@ -73,7 +73,15 @@ public function testHasEnded() {
$this->assertFalse( $notFinishedCampaign->hasEnded() );
}
- public function testIsRunningDataProvider() {
+ /**
+ * @dataProvider isRunningDataProvider
+ */
+ public function testIsRunning( bool $expected, array $data ) {
+ $campaign = $this->newCampaign( $data );
+ $this->assertSame( $expected, $campaign->isRunning() );
+ }
+
+ public function isRunningDataProvider() {
return [
[
true,
@@ -110,12 +118,4 @@ public function testIsRunningDataProvider() {
];
}
- /**
- * @dataProvider testIsRunningDataProvider
- */
- public function testIsRunning( bool $expected, array $data ) {
- $campaign = $this->newCampaign( $data );
- $this->assertSame( $expected, $campaign->isRunning() );
- }
-
}

0 comments on commit 4081da6

Please sign in to comment.