Split laika form tracking #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzhelyazkova
force-pushed
the
split-laika-forms
branch
from
b18f1b9
to
d105e14
Compare
gbirke
approved these changes
Sep 10, 2019
| @@ -134,13 +139,18 @@ export default Vue.extend( { | |||
| document.getElementsByClassName( 'help is-danger' )[ 0 ].scrollIntoView( { behavior: 'smooth', block: 'center', inline: 'nearest' } ); | |||
| return; | |||
| } | |||
| this.$emit( 'submit-donation' ); | |||
| ( this as any ).submitDonationForm(); | |||
There was a problem hiding this comment.
😭 😞
Nothing you can do here with our current setup, I'm really looking forward to Vue 3
There was a problem hiding this comment.
Yeah, I was surprised the function is not recognized by TS.
I know we have other cases like this and there's no TS complaint there, idk 🤷♀️
| <div class="payment-page"> | ||
| <form name="laika-donation-payment-data" | ||
| id="laika-donation-payment-data" | ||
| class="payment-page column is-full" |
There was a problem hiding this comment.
I'd lose the "data" suffix here, because it's kind of implied. "Personal data" is a compund word, but "payment" would suffice imho. But that's just my personal taste and me trying to avoid any hints of AbstractDataFactoryModelManagerContainerHelper.
timEulitz
approved these changes
Sep 10, 2019
tzhelyazkova
force-pushed
the
split-laika-forms
branch
from
d105e14
to
7bed569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: T231555
Split the form in
laikaskin into two forms - payment and personal data.This will enable us to set up more thorough tracking in Matomo.