From 5f128be0fbe3aa223716bb80b6ea2f13cc65b2e3 Mon Sep 17 00:00:00 2001 From: aude Date: Mon, 26 Jun 2017 08:40:53 -0400 Subject: [PATCH 1/3] Tweak comment in DecimalValue::newFromArray Using DataValueDeserializer is one alternative to this method. --- src/DataValues/DecimalValue.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/DataValues/DecimalValue.php b/src/DataValues/DecimalValue.php index 2f4f887..6d42090 100644 --- a/src/DataValues/DecimalValue.php +++ b/src/DataValues/DecimalValue.php @@ -355,10 +355,11 @@ public function getArrayValue() { * * @deprecated since 0.8.3. Static DataValue::newFromArray constructors like this are * underspecified (not in the DataValue interface), and misleadingly named (should be named - * newFromArrayValue). Instead, use DataValue builder callbacks in @see DataValueDeserializer. + * newFromArrayValue). Instead, use the constructor or use DataValue builder + * callbacks. (e.g. @see DataValueDeserializer) * * @param mixed $data Warning! Even if this is expected to be a value as returned by - * @see getArrayValue, callers of this specific newFromArray implementation can not guarantee + * @see getArrayValue, callers of this specific newFromArray implementation cannot guarantee * this. This is not guaranteed to be a string! * * @throws InvalidArgumentException if $data is not in the expected format. Subclasses of From 9d5e7c0ed6394e57f4fbbe314b01e5295fa192ba Mon Sep 17 00:00:00 2001 From: Leszek Manicki Date: Tue, 27 Jun 2017 09:46:48 +0200 Subject: [PATCH 2/3] Fixed punctuation --- src/DataValues/DecimalValue.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DataValues/DecimalValue.php b/src/DataValues/DecimalValue.php index 6d42090..2c25219 100644 --- a/src/DataValues/DecimalValue.php +++ b/src/DataValues/DecimalValue.php @@ -356,7 +356,7 @@ public function getArrayValue() { * @deprecated since 0.8.3. Static DataValue::newFromArray constructors like this are * underspecified (not in the DataValue interface), and misleadingly named (should be named * newFromArrayValue). Instead, use the constructor or use DataValue builder - * callbacks. (e.g. @see DataValueDeserializer) + * callbacks (e.g. @see DataValueDeserializer). * * @param mixed $data Warning! Even if this is expected to be a value as returned by * @see getArrayValue, callers of this specific newFromArray implementation cannot guarantee From c9ca43e64a1b9912b3b2382325754c9686e1931f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thiemo=20M=C3=A4ttig?= Date: Fri, 30 Jun 2017 12:22:32 +0200 Subject: [PATCH 3/3] Update DecimalValue.php --- src/DataValues/DecimalValue.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/DataValues/DecimalValue.php b/src/DataValues/DecimalValue.php index 2c25219..ad6b841 100644 --- a/src/DataValues/DecimalValue.php +++ b/src/DataValues/DecimalValue.php @@ -355,8 +355,7 @@ public function getArrayValue() { * * @deprecated since 0.8.3. Static DataValue::newFromArray constructors like this are * underspecified (not in the DataValue interface), and misleadingly named (should be named - * newFromArrayValue). Instead, use the constructor or use DataValue builder - * callbacks (e.g. @see DataValueDeserializer). + * newFromArrayValue). Instead, just use the constructor. * * @param mixed $data Warning! Even if this is expected to be a value as returned by * @see getArrayValue, callers of this specific newFromArray implementation cannot guarantee