New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LanguageCode class #796

Open
JeroenDeDauw opened this Issue Oct 10, 2018 · 2 comments

Comments

2 participants
@JeroenDeDauw
Member

JeroenDeDauw commented Oct 10, 2018

There should be a LanguageCode class. It is not just a string, it has certain very specific semantics.

This was a proposal by Aleksey.


It is unclear to me if there is any reason to introduce this beyond "encapsulate all primitives". If that is the only reason, then I don't think it is worthwhile to make breaking changes by swapping out the string to a value object everywhere.

Thoughts @addshore @mariushoch @manicki @JonasKress ?

@mariushoch

This comment has been minimized.

Contributor

mariushoch commented Oct 10, 2018

Hm, do you know what kind of semantics were/are supposed to be reflected there specifically? If not, then I guess this is not actionable.

@JeroenDeDauw

This comment has been minimized.

Member

JeroenDeDauw commented Oct 14, 2018

Anyone else see a reason to have such a class? If not, I'll drop this from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment