New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split EntityId into LocalEntityId and ForeinEntityId #798

Open
JeroenDeDauw opened this Issue Oct 10, 2018 · 1 comment

Comments

1 participant
@JeroenDeDauw
Member

JeroenDeDauw commented Oct 10, 2018

Most of the code [should distinguish / distinguishes] those and cannot work with both.

This was a proposal by Aleksey.


Is it true that most code can only work with one type? If so, that does sound like the addition of the foreign concept to EntityId is problematic. I'm not up to speed with the foreign stuff at all so can't judge this.

Thoughts @addshore @mariushoch @manicki @JonasKress ?

@JeroenDeDauw

This comment has been minimized.

Member

JeroenDeDauw commented Oct 10, 2018

Theimo wrote:

I'm not saying the current
architecture does not have problems (it certainly has), but I know for
a fact that the current architecture was intentionally designed so
that all code that was previously able to consume (local) entity IDs
is able to consume prefixed ("foreign") entity IDs. It might be worth
evaluating this. If it turns out that most code can not deal with
both types of IDs, it might indeed be worth redoing this part of the
DataModel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment