Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UnDeserializableValue in SnakDeserializer #21

merged 1 commit into from Jun 3, 2015


Copy link

commented May 21, 2015

needs DataValues JavaScript 0.7.0 when we tag it

@@ -35,7 +35,7 @@ MODULE.SnakDeserializer = util.inherit( 'WbSnakDeserializer', PARENT, {
try {
dataValue = dv.newDataValue( type, value );
} catch( error ) {
dataValue = new dv.UnDeserializableValue( value, type, error );
dataValue = new dv.UnDeserializableValue( type, value, error.message );

This comment has been minimized.

Copy link

thiemowmde May 21, 2015


For reference: Order changed in wmde/DataValuesJavaScript#58, type will change in wmde/DataValuesJavaScript#78, both to be released as 0.7.0.


This comment has been minimized.

Copy link

commented May 21, 2015

I find the commit message confusing. The fact that SnakDeserializer "handles" UnDeserializableValue is not new. However, code looks fine. +2.

@filbertkm filbertkm force-pushed the undeserializable branch 2 times, most recently from 0ac6746 to 283ffeb May 21, 2015
In DataValuesJavaScript 0.7.0, UnDeserializableValue implements
newFromJSON and toJSON.

This change adapts the deserializer to handle UnDeserializableValue
in a compatible manner, and adds tests for UnDeserializableValue.
@filbertkm filbertkm force-pushed the undeserializable branch from 283ffeb to c80f070 Jun 1, 2015
JanZerebecki added a commit that referenced this pull request Jun 3, 2015
Handle UnDeserializableValue in SnakDeserializer
@JanZerebecki JanZerebecki merged commit 9f6cd51 into master Jun 3, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@JanZerebecki JanZerebecki deleted the undeserializable branch Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.