This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add a hidden label for screen readers #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the a11y issue, also given that vue2 doesn't support multiple elements in one component, wrapping everything under a nice <div> Bug: T265245
micgro42
reviewed
Nov 24, 2020
src/components/ValueTypeDropDown.vue
Outdated
| :value="optionItem" | ||
| :key="index" | ||
| <div class="querybuilder__dropdown"> | ||
| <label class="querybuilder__dropdown-label">Value Type</label> |
There was a problem hiding this comment.
I don't think that this will satisfy the test, it probably needs a for="someId" attribute to actually link it to the select. Alternatively, the select could maybe get an [aria-labeledby attribute]9https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute)
There was a problem hiding this comment.
of course, you're right. I will work on it.
micgro42
approved these changes
Nov 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the a11y issue, also given that vue2 doesn't support multiple
elements in one component, wrapping everything under a nice
Bug: T265245