Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run browser tests against netlify #326

Merged
merged 1 commit into from Dec 17, 2020
Merged

Run browser tests against netlify #326

merged 1 commit into from Dec 17, 2020

Conversation

jakobw
Copy link
Member

@jakobw jakobw commented Dec 16, 2020

Our CI browser tests often fail or time out due to problems with Chromatic and running tests against the storybook preview was arguably abusing the service to begin with. Pointing them at netlify will hopefully result in more stable browser test results.

@jakobw jakobw requested a review from a team December 16, 2020 10:59
guergana
guergana previously approved these changes Dec 16, 2020
Copy link
Contributor

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Good job!

Base automatically changed from netlify-deploy to master December 16, 2020 17:34
@jakobw jakobw dismissed guergana’s stale review December 16, 2020 17:34

The base branch was changed.

Our CI browser tests often fail or time out due to problems with
Chromatic and running tests against the storybook preview was arguably
abusing the service to begin with. Pointing them at netlify will
hopefully result in more stable browser test results.
Copy link
Contributor

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again!

@jakobw jakobw merged commit 0e71d48 into master Dec 17, 2020
@jakobw jakobw deleted the browser-test-netlify branch December 17, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants