Apply minimum calculation for the max width #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzhelyazkova
approved these changes
Jan 28, 2021
micgro42
pushed a commit
that referenced
this pull request
Feb 16, 2021
* Apply minimum calculation for the max width * Fix clash between sass min and css min Bug: T269928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fix will cause the OptionsMenu to fall back to a maximum width of 95vw when the viewport width is smaller than 200% of the OptionsMenu parent (arbitrary 5vw reduction chosen to compensate for implementation padding + margin, in consultation with @SaiSan-WMDE).