Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser of extension header with AddHandler #189

Closed
yt8956gh opened this issue Aug 12, 2021 · 4 comments
Closed

Add parser of extension header with AddHandler #189

yt8956gh opened this issue Aug 12, 2021 · 4 comments

Comments

@yt8956gh
Copy link
Contributor

yt8956gh commented Aug 12, 2021

Hi, I'm in the free5gc team and coding for free5GC/N3IWF.
We want to support the extension header in gtp and had seen the related discussion in issue #185. It seems to be improbable to make go-gtp support the field recently.

Therefore, we try to add a new T-PDU parser to support the extension header by AddHandler of UPlaneConn.

However, the handler function is defined out of gtpv1. It's impossible to access some critical parameters (e.g. tpduSet, tpduCh for sending T-PDU) due to the lack of related public methods. Is there any solution for them? Thank you in advance !!

@wmnsk
Copy link
Owner

wmnsk commented Aug 20, 2021

Good news is that I started working on implementing the Extension Header. What’s bad is it’ll take some time to finish (hopefully this weekend?).

@wmnsk
Copy link
Owner

wmnsk commented Aug 20, 2021

Oh I just saw your PR, what a coincidence! 😁

@yt8956gh
Copy link
Contributor Author

Hi, @wmnsk
I just saw your comment pop out when I key this comment.
Hope this PR can help !!

@wmnsk
Copy link
Owner

wmnsk commented Aug 21, 2021

As talked in your PR, I’ve modified the implementation and tagged v0.7.28. Docs here: https://github.com/wmnsk/go-gtp/blob/master/gtpv1/README.md#handling-extension-headers

@wmnsk wmnsk closed this as completed Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants