Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo intermittently crashes on popover update #51

Closed
wmww opened this issue Jul 30, 2020 · 3 comments · Fixed by #52
Closed

Demo intermittently crashes on popover update #51

wmww opened this issue Jul 30, 2020 · 3 comments · Fixed by #52

Comments

@wmww
Copy link
Owner

wmww commented Jul 30, 2020

Possibly related to #47

To reproduce:

  • Open gtk-layer-demo
  • Open the "set margin" popover
  • Play around with it a little (close and re-run gtk-layer-demo if nothing happens)
  • Eventually you will see:
../../../../src/cairo-surface.c:930: cairo_surface_reference: Assertion `CAIRO_REFERENCE_COUNT_HAS_REFERENCE (&surface->ref_count)' failed.

When gtk-layer-demo is passed --no-layer-shell, neither the flicker described in #47 or this happens, indicating it's definitly a gtk-layer-shell problem.

NOTE: this happens on Sway, but doesn't appear to effect gtk-layer-demo running on Mir. This is strange.

@wmww
Copy link
Owner Author

wmww commented Jul 30, 2020

It appears both this and #47 are indirectly caused by us committing our shared wl_surface when GTK doesn't expect it. We seem to be committing after GTK has attached a buffer but before GTK has committed it. This leads the compositor to release that buffer while GTK thinks it's still uncommitted and all hell breaks loose. Still working on the ideal solution.

@wmww wmww mentioned this issue Jul 30, 2020
@wmww wmww closed this as completed in #52 Jul 30, 2020
@alebastr
Copy link
Contributor

alebastr commented Aug 3, 2020

@wmww does this deserve a patch release (0.2.1) or there's something else you want to address before that?
I don't see the crash on any apps other than gtk-layer-demo but this might just mean that I'm lucky enough.

@wmww
Copy link
Owner Author

wmww commented Aug 3, 2020

I want to investigate #47 more and possibly add some other stuff before a release. That should happen within a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants