Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(format): use capsule-type serialization for fs nodes #265

Merged
merged 2 commits into from May 17, 2023

Conversation

appcypher
Copy link
Member

Summary

Share payloads already serialize to the capsule-type format as part of the stabilization goals of wnfs but the filesystem nodes still serialize to old format.

This PR implements said serialization format for private and public nodes.

Test plan (required)

scripts/rs-wnfs.sh test

Closing issues

Closes #248

@appcypher appcypher requested a review from a team as a code owner May 17, 2023 08:05
@appcypher appcypher changed the title Use capsule-type serialization for fs nodes chore(serialization): use capsule-type serialization for fs nodes May 17, 2023
@appcypher appcypher changed the title chore(serialization): use capsule-type serialization for fs nodes chore(format): use capsule-type serialization for fs nodes May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #265 (23f9ba0) into main (5ed87fe) will decrease coverage by 1.86%.
The diff coverage is 60.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   61.92%   60.06%   -1.86%     
==========================================
  Files          35       38       +3     
  Lines        2676     2697      +21     
  Branches      657      666       +9     
==========================================
- Hits         1657     1620      -37     
- Misses        563      624      +61     
+ Partials      456      453       -3     
Impacted Files Coverage Δ
wnfs/examples/privateref.rs 0.00% <0.00%> (ø)
wnfs/src/private/encrypted.rs 66.66% <0.00%> (+4.16%) ⬆️
wnfs/src/private/node/header.rs 85.48% <0.00%> (-1.19%) ⬇️
wnfs/src/private/node/serializable.rs 0.00% <0.00%> (ø)
wnfs/src/private/share.rs 64.49% <0.00%> (+0.25%) ⬆️
wnfs/src/public/node/serializable.rs 0.00% <0.00%> (ø)
wnfs/src/public/node/node.rs 51.35% <42.85%> (ø)
wnfs/src/private/node/node.rs 65.18% <55.55%> (+3.28%) ⬆️
wnfs/src/public/directory.rs 70.42% <68.75%> (+0.15%) ⬆️
wnfs/src/private/directory.rs 67.84% <69.69%> (-3.98%) ⬇️
... and 3 more

... and 7 files with indirect coverage changes

Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you :)

wnfs-common/src/blockstore.rs Show resolved Hide resolved
wnfs/src/private/encrypted.rs Show resolved Hide resolved
wnfs/src/private/node/node.rs Show resolved Hide resolved
wnfs/src/private/node/node.rs Show resolved Hide resolved
wnfs/src/private/node/node.rs Outdated Show resolved Hide resolved
wnfs/src/private/node/serializable.rs Show resolved Hide resolved
wnfs/src/private/share.rs Show resolved Hide resolved
@appcypher appcypher merged commit 020aac2 into main May 17, 2023
10 checks passed
@appcypher appcypher deleted the appcypher/capsule-type-serialisation branch May 17, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use capsule-type based serialization
2 participants