Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search_latest on the root directory and implement searchLatest in wasm bindings #310

Merged
merged 21 commits into from Jul 21, 2023

Conversation

matheus23
Copy link
Member

The title pretty much covers it.

This PR also includes a previously failing test case, and a wasm test case testing the new API.

Fixes #309

@matheus23 matheus23 requested a review from a team as a code owner July 19, 2023 15:52
@matheus23 matheus23 self-assigned this Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #310 (5a27e1c) into matheus23/sha3-to-blake3 (05529f5) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           matheus23/sha3-to-blake3     #310      +/-   ##
============================================================
+ Coverage                     56.22%   56.25%   +0.02%     
============================================================
  Files                            43       43              
  Lines                          3189     3198       +9     
  Branches                        770      774       +4     
============================================================
+ Hits                           1793     1799       +6     
+ Misses                          904      903       -1     
- Partials                        492      496       +4     
Impacted Files Coverage Δ
wnfs/src/private/directory.rs 67.78% <0.00%> (-0.24%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Member

@icidasset icidasset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@appcypher appcypher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Base automatically changed from matheus23/sha3-to-blake3 to main July 21, 2023 11:46
@matheus23 matheus23 merged commit 00f5b16 into main Jul 21, 2023
10 checks passed
@matheus23 matheus23 deleted the matheus23/search-latest branch July 21, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm: Expose .searchLatest on PrivateNode
3 participants