Skip to content

Loading…

Update table layout / fix a bug #423

Merged
merged 1 commit into from

2 participants

@genuino2

Fixed THEAD in table layout header, now table has a html5 valid code.

<table>
<thead><tr><th></th></tr></thead>
<tbody><tr><td></td></tr></tbody>
</table>

I've not fixed simplecart.min.js

@genuino2 genuino2 Update table layout / fix a bug
Fixed THEAD in table layout header, now table has a html5 valid code.
<table>
<thead><tr><th></th></tr></thead>
<tbody><tr><td></td></tr></tbody>
</table>
I've not fixed simplecart.min.js
a11eab3
@darkchaz darkchaz merged commit 51a9a38 into wojodesign:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 16, 2013
  1. @genuino2

    Update table layout / fix a bug

    genuino2 committed
    Fixed THEAD in table layout header, now table has a html5 valid code.
    <table>
    <thead><tr><th></th></tr></thead>
    <tbody><tr><td></td></tr></tbody>
    </table>
    I've not fixed simplecart.min.js
Showing with 5 additions and 1 deletion.
  1. +5 −1 simpleCart.js
View
6 simpleCart.js
@@ -625,7 +625,9 @@
TR = isTable ? "tr" : "div",
TH = isTable ? 'th' : 'div',
TD = isTable ? 'td' : 'div',
+ THEAD = isTable ? 'thead' : 'div',
cart_container = simpleCart.$create(TABLE),
+ thead_container = simpleCart.$create(THEAD),
header_container = simpleCart.$create(TR).addClass('headerRow'),
container = simpleCart.$(selector),
column,
@@ -636,7 +638,9 @@
container.html(' ').append(cart_container);
- cart_container.append(header_container);
+ cart_container.append(thead_container);
+
+ thead_container.append(header_container);
// create header
Something went wrong with that request. Please try again.