Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z-index usage is subpar leading to clipping issues #13

Open
wojtossfm opened this issue Apr 27, 2021 · 2 comments
Open

z-index usage is subpar leading to clipping issues #13

wojtossfm opened this issue Apr 27, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@wojtossfm
Copy link
Owner

While the effect on a single character is correct when multiple character cross this seems to break.

A solution seems to be:

  • to not actually set the z-index
  • instead use it as a guide when ordering the children for each parent

Seemed in the scenes where I tried it this led to the expected ordering visually being maintained while removing the issue of multiple characters crossing and sprites clipping over each other in awkward ways.

@wojtossfm wojtossfm added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 27, 2021
@wojtossfm
Copy link
Owner Author

Not sure this is easily solvable and is in part an animation/character issue rather than an issue with the importer itself. The solution I mentioned in the initial comment would work for simple cases but there are ones where z-index appears to be used to change order between different layers of the hierarchy where simple ordering of children in godot wouldn't be enough. I'll leave this open as an enhancement could still be done to limit usage of z-index in the simpler cases and make it an importer option.

@wojtossfm
Copy link
Owner Author

A potential solution is also using a y-sort node (in case someone comes looking for an easy solve)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant