Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiFive HiFive (FE310) RISC-V support #14

Merged
merged 21 commits into from Jul 15, 2019

Conversation

Projects
None yet
2 participants
@dgarske
Copy link
Contributor

commented Jun 7, 2019

  • HiFive1 HAL Support for PLL Clock, UART, RTC and Flash QSPI Erase/Write.
  • HiFive1 update demo application for accepting firmware updates over UART.
  • Added test-update-server application for pushing firmware image over UART.
  • Fixes for building with make SIGN=ECC256.
  • Improvements to wolfCrypt user_settings.h.
  • General library cleanup (license headers and formatting)
  • Updated the wolfSSL submodule to latest.
  • Documentation updates including new Targets.md section for hardare instructions.
SiFive HiFive (FE310) RISC-V support
* HiFive1 HAL Support for PLL Clock, UART, RTC and Flash QSPI Erase/Write.
* HiFive1 update demo application for accepting firmware updates over UART.
* Added test-update-server application for pushing firmware image over UART.
* Fixes for building with `make SIGN=ECC256`.
* Improvements to wolfCrypt `user_settings.h`.
* General library cleanup (license headers and formatting)
* Updated the wolfSSL submodule to latest.
* Documentation updates including new `Targets.md` section for hardare instructions.

@dgarske dgarske self-assigned this Jun 7, 2019

@dgarske dgarske requested a review from danielinux Jun 7, 2019

dgarske added some commits Jun 7, 2019

Fix for `ARCH_FLASH_OFFSET` when make script is gathering `.wolfboot-…
…offset` and `.wolfboot-partition-size` files. Updates to Target.md. Cleanups to test tools.
.gitignore Outdated
.wolfboot-partition-size
factory.bin
wolfboot-align.bin
wolfboot.bin

This comment has been minimized.

Copy link
@danielinux

danielinux Jun 10, 2019

Collaborator

Let's add *.bin


### wolfBoot configuration

The default wolfBoot configuration will add a second stage bootloader, leaving the stock "double tap" bootloader for safety.

This comment has been minimized.

Copy link
@danielinux

danielinux Jun 10, 2019

Collaborator

'for safety' ... it's not clear to me how leaving the doubletap as stage1 increases safety

This comment has been minimized.

Copy link
@danielinux

danielinux Jun 10, 2019

Collaborator

also, from the addresses seems like you are actually replacing it

```


2. `include/target.h`

This comment has been minimized.

Copy link
@danielinux

danielinux Jun 10, 2019

Collaborator

Review addresses as discussed f2f

Show resolved Hide resolved arch.mk Outdated

```c
#define WOLFBOOT_SECTOR_SIZE 0x10000
#define WOLFBOOT_PARTITION_BOOT_ADDRESS 0x20010000

This comment has been minimized.

Copy link
@danielinux

danielinux Jun 10, 2019

Collaborator

This is the partition address for the main BOOT image, 0x100 before the application entry point

Show resolved Hide resolved docs/Targets.md Outdated



## STM32-F407

This comment has been minimized.

Copy link
@danielinux

danielinux Jun 10, 2019

Collaborator

This should be the first target described in Targets.md since it's the default (CI)

Show resolved Hide resolved include/target.h Outdated

dgarske added some commits Jun 10, 2019

Resolved peer review items. Thanks Daniele. Documentation improvement…
…s. Added open() check for update server example.

@dgarske dgarske assigned danielinux and unassigned dgarske Jun 10, 2019

@danielinux

This comment has been minimized.

Copy link
Collaborator

commented Jun 16, 2019

CI tests passing, no regressions.

One known bug left in test-app/hifive.c (long jump/memory symbols)

@danielinux

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

@dgarske could you please review my latest changes? eSPI driver works in the test-application as well now.

@dgarske

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

PR Approved! Thanks Daniele!

@danielinux danielinux merged commit 63eb744 into master Jul 15, 2019

@danielinux danielinux deleted the hifive1-hal branch Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.