Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RsaUnPad constant time when Block Type 2 message #1950

Merged
merged 1 commit into from Dec 6, 2018

Conversation

SparkiDev
Copy link
Contributor

No description provided.

@toddouska toddouska assigned dgarske and unassigned toddouska Dec 5, 2018
@toddouska
Copy link
Contributor

David please review. If you approve, go ahead and merge.

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SparkiDev : Code changes look good. Found a missing XFREE case that needs fixed. Also can you describe the purpose of TEST_UNPAD_CONSTANT_TIME and how to use it? Perhaps you can also send Todd and I an email about how you validated this was constant time? Thanks

fp_int *t;
#endif

#ifdef WOLFSSL_SMALL_STACK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XFREE for t appears to be missing for the small stack case?

@dgarske dgarske assigned SparkiDev and unassigned dgarske Dec 5, 2018
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean!

@dgarske dgarske merged commit d6ebd2d into wolfSSL:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants