New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RsaUnPad constant time when Block Type 2 message #1950
Conversation
ecb1286
to
3c0deab
Compare
|
David please review. If you approve, go ahead and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SparkiDev : Code changes look good. Found a missing XFREE case that needs fixed. Also can you describe the purpose of TEST_UNPAD_CONSTANT_TIME and how to use it? Perhaps you can also send Todd and I an email about how you validated this was constant time? Thanks
| fp_int *t; | ||
| #endif | ||
|
|
||
| #ifdef WOLFSSL_SMALL_STACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The XFREE for t appears to be missing for the small stack case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sean!
No description provided.