New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RsaUnPad constant time when Block Type 2 message #1950

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@SparkiDev
Copy link
Contributor

SparkiDev commented Dec 2, 2018

No description provided.

@SparkiDev SparkiDev force-pushed the SparkiDev:rsa_unpad branch 2 times, most recently from ecb1286 to 3c0deab Dec 2, 2018

@toddouska toddouska assigned dgarske and unassigned toddouska Dec 5, 2018

@toddouska

This comment has been minimized.

Copy link
Contributor

toddouska commented Dec 5, 2018

David please review. If you approve, go ahead and merge.

@dgarske
Copy link
Contributor

dgarske left a comment

@SparkiDev : Code changes look good. Found a missing XFREE case that needs fixed. Also can you describe the purpose of TEST_UNPAD_CONSTANT_TIME and how to use it? Perhaps you can also send Todd and I an email about how you validated this was constant time? Thanks

fp_int *t;
#endif

#ifdef WOLFSSL_SMALL_STACK

This comment has been minimized.

@dgarske

dgarske Dec 5, 2018

Contributor

The XFREE for t appears to be missing for the small stack case?

@dgarske dgarske assigned SparkiDev and unassigned dgarske Dec 5, 2018

@SparkiDev SparkiDev force-pushed the SparkiDev:rsa_unpad branch from 3c0deab to ab03f92 Dec 5, 2018

@SparkiDev SparkiDev assigned dgarske and unassigned SparkiDev Dec 6, 2018

@dgarske

dgarske approved these changes Dec 6, 2018

Copy link
Contributor

dgarske left a comment

Thanks Sean!

@dgarske dgarske merged commit d6ebd2d into wolfSSL:master Dec 6, 2018

17 checks passed

CAVP self test Passed
Details
Clang --enable-all Check Static Analysis: OK
Details
Disable Options Test Passed
Details
Enable Options part A Passed
Details
Enable Options part B Passed
Details
Enable Options part C Passed
Details
Fips Check Passed
Details
New File Make Dist Check Passed
Details
Pull Request Manager All Tests Successfully Launched.
Details
Scan-Build Analysis Good
Details
Testing known customer configurations Passed
Details
Valgrind Test No Leaks or Issues
Details
Visual Studio Build Test Passed
Details
Windows FIPS Create Package Passed
Details
Windows FIPS Test Passed
Details
certificate renewal scripts check OK
Details
fsanitize=address test fsanitize check: OK
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment