Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Google WebRTC #2462

Merged
merged 5 commits into from Sep 27, 2019

Conversation

@dgarske
Copy link
Contributor

commented Sep 10, 2019

  • Adds the following openssl compatibility API's:
    • SSL_CIPHER_get_id
    • SSL_CIPHER_get_rfc_name
    • SSL_get_cipher_by_value
    • X509_print_ex
    • X509_NAME_add_entry_by_NID
    • X509_time_adj
    • X509_time_adj_ex
    • DTLSv1_get_timeout
    • DTLSv1_handle_timeout
    • DTLSv1_set_initial_timeout_duration
    • SSL_CTX_set_current_time_cb
    • PEM_write_bio_RSA_PUBKEY
    • PEM_read_bio_RSA_PUBKEY
    • PEM_write_bio_PUBKEY
    • EVP_PKEY_missing_parameters
    • EVP_PKEY_cmp
    • BN_is_negative
    • BIO_set_retry_write
  • Improvements to the notBefore and notAfter date handling.
  • Improvements to BIO and BIO_METHOD
    • Moved structure to public area to allow for dereferencing
    • Renamed members to provide compatibility.
    • Added support for custom BIO methods for read/write.
  • Added advanced openssl compatibility test cases for key and certificate generation.
  • Fix for ASN1_STRING_set to allow NULL data.
  • Fix to populate public key information on EVP_PKEY_assign_RSA and EVP_PKEY_assign_EC_KEY.
  • Fix naming for X509_get_notBefore and X509_get_notAfter functions.
  • Added wc_EccPublicKeyDerSize.
  • Improvements to wc_RsaPublicKeyDerSize, so dummy memory doesn't have to be allocated.
  • Made the wc_*PublicKeyDerSize functions public.
  • Eliminate use of snprintf for UTC to generalized time conversion in wolfSSL_ASN1_TIME_to_generalizedtime.
@dgarske dgarske self-assigned this Sep 10, 2019
@dgarske dgarske force-pushed the dgarske:webrtc branch from a24f0fa to 1fadc3e Sep 10, 2019
@dgarske dgarske requested a review from toddouska Sep 11, 2019
@dgarske dgarske force-pushed the dgarske:webrtc branch 3 times, most recently from 90b4051 to 867d81f Sep 16, 2019
@dgarske dgarske assigned toddouska and unassigned dgarske Sep 18, 2019
@dgarske dgarske force-pushed the dgarske:webrtc branch from a144179 to cc9e0c7 Sep 20, 2019
@dgarske

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

@ejohnstown and @JacobBarthelmeh : Finished the rebase -> force push. Lets see how Jenkins does with it.

@dgarske dgarske force-pushed the dgarske:webrtc branch 2 times, most recently from 8dae6d4 to a2e03a3 Sep 20, 2019
@dgarske

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

retest this please

@dgarske dgarske force-pushed the dgarske:webrtc branch from a2e03a3 to 0b49ba6 Sep 20, 2019
@dgarske dgarske assigned dgarske and unassigned ejohnstown and JacobBarthelmeh Sep 23, 2019
@dgarske dgarske closed this Sep 24, 2019
@dgarske dgarske force-pushed the dgarske:webrtc branch from 6952f8e to bcd8a52 Sep 24, 2019
@dgarske dgarske reopened this Sep 24, 2019
@dgarske dgarske force-pushed the dgarske:webrtc branch 2 times, most recently from d016b61 to e1882f8 Sep 24, 2019
@dgarske dgarske requested review from ejohnstown and JacobBarthelmeh Sep 25, 2019
@dgarske dgarske removed their assignment Sep 26, 2019
dgarske added 4 commits Sep 24, 2019
  - SSL_CIPHER_get_id
  - SSL_CIPHER_get_rfc_name
  - SSL_get_cipher_by_value
  - X509_print_ex
  - X509_NAME_add_entry_by_NID
  - X509_time_adj
  - X509_time_adj_ex
  - DTLSv1_get_timeout
  - DTLSv1_handle_timeout
  - DTLSv1_set_initial_timeout_duration
  - SSL_CTX_set_current_time_cb
  - PEM_write_bio_RSA_PUBKEY
  - PEM_read_bio_RSA_PUBKEY
  - PEM_write_bio_PUBKEY
  - EVP_PKEY_missing_parameters
  - EVP_PKEY_cmp
  - BN_is_negative
  - BIO_set_retry_write
* Improvements to the notBefore and notAfter date handling.
* Improvements to BIO and BIO_METHOD
  - Moved structure to public area to allow for dereferencing
  - Renamed members to provide compatibility.
  - Added support for custom BIO methods for read/write.
* Added advanced openssl compatibility test cases for key and certificate generation.
* Fix for `ASN1_STRING_set` to allow NULL data.
* Fix to populate public key information on `EVP_PKEY_assign_RSA` and `EVP_PKEY_assign_EC_KEY`.
* Fix naming for `X509_get_notBefore` and `X509_get_notAfter` functions.
* Added `wc_EccPublicKeyDerSize`.
* Improvements to `wc_RsaPublicKeyDerSize`, so dummy memory doesn't have to be allocated.
* Made the `wc_*PublicKeyDerSize` functions public.
* Eliminate use of snprintf for UTC to generalized time conversion in `wolfSSL_ASN1_TIME_to_generalizedtime`.
@dgarske dgarske force-pushed the dgarske:webrtc branch from 560f467 to 34e0eb4 Sep 26, 2019
Copy link
Contributor

left a comment

Couple of comments, otherwise looks good.

src/ssl.c Show resolved Hide resolved
src/ssl.c Show resolved Hide resolved
src/ssl.c Show resolved Hide resolved
src/ssl.c Show resolved Hide resolved
wolfssl/ssl.h Outdated Show resolved Hide resolved
@dgarske dgarske assigned dgarske and unassigned ejohnstown Sep 27, 2019
@dgarske dgarske requested review from JacobBarthelmeh and ejohnstown Sep 27, 2019
…`ptr`. Revert change to BIO_set_fd.
@dgarske dgarske force-pushed the dgarske:webrtc branch from d423380 to 4c89a21 Sep 27, 2019
@dgarske dgarske assigned JacobBarthelmeh and ejohnstown and unassigned dgarske Sep 27, 2019
@ejohnstown ejohnstown merged commit 43476e8 into wolfSSL:master Sep 27, 2019
18 checks passed
18 checks passed
CAVP self test Passed
Details
Clang --enable-all Check Static Analysis: OK
Details
Disable Options Test Passed
Details
Enable Options part A Passed
Details
Enable Options part B Passed
Details
Enable Options part C Passed
Details
Fips Check Passed
Details
New File Make Dist Check Passed
Details
Pull Request Manager All Tests Successfully Launched.
Details
Scan-Build Analysis Good
Details
Testing known customer configurations Passed
Details
Valgrind Test No Leaks or Issues
Details
Visual Studio Build Test Passed
Details
Windows FIPS Create Package Passed
Details
Windows FIPS Test Passed
Details
Xilinx Petalinux Test OK
Details
certificate renewal scripts check OK
Details
fsanitize=address test fsanitize check: OK
Details
@dgarske dgarske deleted the dgarske:webrtc branch Sep 27, 2019
dgarske added a commit to dgarske/wolfssl that referenced this pull request Oct 17, 2019
…olfSSL#2462. These are not openssl compatibility functions, but are used by JSSE.
dgarske added a commit to dgarske/wolfssl that referenced this pull request Oct 17, 2019
…olfSSL#2462. These are not openssl compatibility functions, but are used by JSSE.
dgarske added a commit to dgarske/wolfssl that referenced this pull request Oct 17, 2019
…olfSSL#2462. These are not openssl compatibility functions, but are used by JSSE.
dgarske added a commit to dgarske/wolfssl that referenced this pull request Oct 17, 2019
…olfSSL#2462. These are not openssl compatibility functions, but are used by JSSE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.