Remove WOLFSSL_SESSION_TYPE_REF buffers from WOLFSSL_SESSION

[julek-wolfssl]

ZD 14662

• Refactor ticket size to not accidentally go over WOLFSSL_TICKET_ENC_SZ
  • Optimize memory usage. Write directly to ssl->session->ticket in CreateTicket() and use a hash to make sure the InternalTicket was encrypted.
  • DoClientTicket does not fatally error out anymore. Errors in the ticket result in the ticket being rejected instead.

[dgarske]

@julek-wolfssl not sure if it is your PR changes, but this is consistently failing Jenkins:

./configure -enable-sp-math-all --enable-all --enable-intelasm --enable-sp-asm && make
FAIL: scripts/unit.test

[julek-wolfssl]

@dgarske The Jenkins issue was due to the size of the ticket object exceeding ssl->session->staticTicket. I'm not sure how my PR triggered that but I pushed a major overhaul to the ticket generation. I've made it more efficient and less error prone since the size is now calculated based on components and asserted to make sure everything fits where it should.

[dgarske]

Refactor looks good. Seems like a minor build macro issue...

[1;38;5;243m--enable-sslv3 --enable-tlsv10 --enable-certgen --enable-certext --enable-keygen --enable-testcert --enable-ecc --enable-supportedcurves --enable-curve25519 --enable-aesgcm --enable-camellia --enable-intelasm --enable-intelrand --disable-hashdrbg --enable-des3 --enable-ocspstapling --enable-ocspstapling2 --enable-certreq --enable-sha224 --enable-opensslextra --enable-psk --enable-sni --enable-alpn --enable-renegotiation-indication --enable-fpecc --disable-harden C_EXTRA_FLAGS="-DHAVE_FFDHE_2048 -DHAVE_FFDHE_3072 -DHAVE_FFDHE_4096 -DHAVE_FFDHE_6144 -DHAVE_FFDHE_8192 -DMAX_CERTIFICATE_SZ=20000 -DWC_CTC_MAX_ALT_SIZE=20000 -DWOLFSSL_ALT_NAMES -DWOLFSSL_STATIC_RSA -DUSE_QAE_THREAD_LS -DWC_ASYNC_NO_AES -DWC_ASYNC_NO_HASH -DUSE_QAE_STATIC_MEM -DWC_NO_ASYNC_THREADING -DHAVE_IO_TIMEOUT -DDEFAULT_TIMEOUT_SEC=2 -DFP_ENTRIES=63 -DFP_LUT=12 -DWOLFSSL_ALWAYS_VERIFY_CB -DWOLFSSL_ALT_CERT_CHAINS -DWC_NO_CACHE_RESISTANT -DTFM_HUGE_SET -DWOLFSSL_NONBLOCK_OCSP -DHAVE_INTEL_MULX -mavx2 -mfma -fgnu89-inline"�[0m
The case with C_EXTRA_FLAGS + double-quotes
EXTRACTED_CFLAGS = -DHAVE_FFDHE_2048 -DHAVE_FFDHE_3072 -DHAVE_FFDHE_4096 -DHAVE_FFDHE_6144 -DHAVE_FFDHE_8192 -DMAX_CERTIFICATE_SZ=20000 -DWC_CTC_MAX_ALT_SIZE=20000 -DWOLFSSL_ALT_NAMES -DWOLFSSL_STATIC_RSA -DUSE_QAE_THREAD_LS -DWC_ASYNC_NO_AES -DWC_ASYNC_NO_HASH -DUSE_QAE_STATIC_MEM -DWC_NO_ASYNC_THREADING -DHAVE_IO_TIMEOUT -DDEFAULT_TIMEOUT_SEC=2 -DFP_ENTRIES=63 -DFP_LUT=12 -DWOLFSSL_ALWAYS_VERIFY_CB -DWOLFSSL_ALT_CERT_CHAINS -DWC_NO_CACHE_RESISTANT -DTFM_HUGE_SET -DWOLFSSL_NONBLOCK_OCSP -DHAVE_INTEL_MULX -mavx2 -mfma -fgnu89-inline
Testing CONFIG_REMAINDER = --enable-sslv3 --enable-tlsv10 --enable-certgen --enable-certext --enable-keygen --enable-testcert --enable-ecc --enable-supportedcurves --enable-curve25519 --enable-aesgcm --enable-camellia --enable-intelasm --enable-intelrand --disable-hashdrbg --enable-des3 --enable-ocspstapling --enable-ocspstapling2 --enable-certreq --enable-sha224 --enable-opensslextra --enable-psk --enable-sni --enable-alpn --enable-renegotiation-indication --enable-fpecc --disable-harden 
�[1;32mConfigure RESULT = 0�[0m

make[2]: warning: -j9 forced in submake: resetting jobserver mode.
In file included from src/internal.c:89:
./wolfssl/internal.h:3671:5: error: unknown type name ‘TicketNonce’
 3671 |     TicketNonce        ticketNonce;       /* Nonce used to derive PSK */
      |     ^~~~~~~~~~~
In file included from src/wolfio.c:37:

[julek-wolfssl]

I misunderstood when TicketNonce should be defined. Did && instead of ||.

[dgarske]

I also verified async still works (--enable-all --enable-asynccrypt).

[dgarske]

Multi-test came up with an error:

[all-gcc-c99] [4 of 18] [802ff84160]
    configure...   real 0m16.293s  user 0m11.224s  sys 0m6.879s
    build...In file included from src/internal.c:89:
src/internal.c: In function ‘CreateTicket’:
./wolfssl/internal.h:1710:18: error: redefinition of typedef ‘_args_test’ [-Werror=pedantic]
 1710 |     typedef char _args_test[sizeof((x)) >= sizeof((y)) ? 1 : -1];    \
      |                  ^~~~~~~~~~
src/internal.c:33395:9: note: in expansion of macro ‘WOLFSSL_ASSERT_SIZEOF_GE’
33395 |         WOLFSSL_ASSERT_SIZEOF_GE(et->enc_ticket, *it);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
./wolfssl/internal.h:1710:18: note: previous declaration of ‘_args_test’ was here
 1710 |     typedef char _args_test[sizeof((x)) >= sizeof((y)) ? 1 : -1];    \
      |                  ^~~~~~~~~~
src/internal.c:33394:9: note: in expansion of macro ‘WOLFSSL_ASSERT_SIZEOF_GE’
33394 |         WOLFSSL_ASSERT_SIZEOF_GE(ssl->session->staticTicket, *et);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
./wolfssl/internal.h:1710:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 1710 |     typedef char _args_test[sizeof((x)) >= sizeof((y)) ? 1 : -1];    \
      |     ^~~~~~~
src/internal.c:33395:9: note: in expansion of macro ‘WOLFSSL_ASSERT_SIZEOF_GE’
33395 |         WOLFSSL_ASSERT_SIZEOF_GE(et->enc_ticket, *it);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:6176: src/libwolfssl_la-internal.lo] Error 1

[julek-wolfssl]

Wrapped WOLFSSL_ASSERT_SIZEOF_GE in a do..while to allow multiple uses in one function.

[dgarske]

Testing DEFAULT: --disable-inline
�[1;32mConfigure RESULT = 0�[0m

make[2]: warning: -j9 forced in submake: resetting jobserver mode.
wolfcrypt/src/misc.c:808:28: error: no previous prototype for ‘MakeWordFromHash’ [-Werror=missing-prototypes]
  808 | WC_STATIC WC_INLINE word32 MakeWordFromHash(const byte* hashID)
      |                            ^~~~~~~~~~~~~~~~
wolfcrypt/src/misc.c:821:28: error: no previous prototype for ‘HashObject’ [-Werror=missing-prototypes]
  821 | WC_STATIC WC_INLINE word32 HashObject(const byte* o, word32 len, int* error)
      |                            ^~~~~~~~~~
cc1: all warnings being treated as errors```

[dgarske]

Please revert back to using 32-bit here! This was specifically changed to 32-bit to avoid an alignment padding issue. See #4908

[dgarske]

Also please add an inline code comment to prevent this from changing again in the future. The structure element enc_len needs to be 32-bit aligned.

[dgarske]

From @julek-wolfssl :

I disagree that this (referring to your last comment in 5476) needs to be reverted. I took a look at the original issue and the cause of the error was that in 5.2 the InternalTicket looked like this:

    /* our ticket format */
    typedef struct InternalTicket {
        ProtocolVersion pv;                    /* version when ticket created */
        byte            suite[SUITE_LEN];      /* cipher suite when created */
        byte            msecret[SECRET_LEN];   /* master secret */
        word32          timestamp;             /* born on */
        word16          haveEMS;               /* have extended master secret */
#ifdef WOLFSSL_TLS13
        word32          ageAdd;                /* Obfuscation of age */
        word16          namedGroup;            /* Named group used */
        TicketNonce     ticketNonce;           /* Ticket nonce */
    #ifdef WOLFSSL_EARLY_DATA
        word32          maxEarlyDataSz;        /* Max size of early data */
    #endif
#endif
    } InternalTicket;

It has word32 and word16 members. I fixed this in 617eda9 by changing everything to byte buffers. I ran into the same issue described in 4887 and changing the struct over to byte arrays was the correct fix.

[dgarske]

FYI: enc_len used to be word16, then we changed it to word32 and now changing it back to word16.