Heli/Helipad migration script #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A step on the way to allowing the use of previously-built helicopters and pads without needing to completely remove both original and forked mods (thus losing all entities/items related to helicopters).
|
I… Hmm. This was a draft on purpose, because only migrating these two object types makes the mod look like it should work but actually doesn't fix anything. 😅 Not a big deal to have merged it, I guess, as long as you wait to release until the rest of the migration logic is implemented (or back this out and defer to a later version). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed a step on the way to allowing the use of previously-built helicopters and pads without needing to completely remove both original and forked mods (thus losing all entities/items related to helicopters).
This is based on the
/fixchoppacommand from the "Choppers" fork, and extended to also handle helipads. It does not yet restore the autopilot functionality; clicking things in the remote GUI causes no apparent errors, but also doesn't do anything.Since this isn't actually complete, I'm opening it as a draft PR.